Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit a2aa631

Browse files
committedDec 22, 2021
Fix after rebase
1 parent ee7a7f7 commit a2aa631

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed
 

‎src/DependencyInjection/Compiler/IdentifyCallbackServiceIdsPass.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ private function resolveServiceIdAndMethod(ContainerBuilder $container, ?array &
7171
$alias = $container->getAlias($id);
7272
$id = (string) $alias;
7373
$definition = $container->getDefinition($id);
74-
} catch (ServiceNotFoundException | InvalidArgumentException $e) {
74+
} catch (ServiceNotFoundException|InvalidArgumentException $e) {
7575
if ($throw) {
7676
throw $e;
7777
}

‎src/Generator/TypeBuilder.php

+5-4
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
use Overblog\GraphQLBundle\ExpressionLanguage\ExpressionLanguage as EL;
3232
use Overblog\GraphQLBundle\Generator\Config\Arg;
3333
use Overblog\GraphQLBundle\Generator\Config\Callback;
34+
use Overblog\GraphQLBundle\Generator\Config\Config as GeneratorConfig;
3435
use Overblog\GraphQLBundle\Generator\Config\Field;
3536
use Overblog\GraphQLBundle\Generator\Config\Validation;
3637
use Overblog\GraphQLBundle\Generator\Converter\ExpressionConverter;
@@ -79,7 +80,7 @@ final class TypeBuilder
7980
private ExpressionConverter $expressionConverter;
8081
private PhpFile $file;
8182
private string $namespace;
82-
private Config\Config $config;
83+
private GeneratorConfig $config;
8384
private string $type;
8485
private string $currentField;
8586
private string $gqlServices = '$'.TypeGenerator::GRAPHQL_SERVICES;
@@ -114,7 +115,7 @@ public function __construct(ExpressionConverter $expressionConverter, string $na
114115
public function build(array $config, string $type): PhpFile
115116
{
116117
// This values should be accessible from every method
117-
$this->config = new Config\Config($config);
118+
$this->config = new GeneratorConfig($config);
118119
$this->type = $type;
119120

120121
$this->file = PhpFile::new()->setNamespace($this->namespace);
@@ -439,7 +440,7 @@ private function buildScalarCallback($callback, string $fieldName)
439440
*
440441
* @throws GeneratorException
441442
*/
442-
private function buildResolver(Callback $resolver, ?array $groups = null): ?GeneratorInterface
443+
private function buildResolver(Callback $resolver, ?array $groups = null): GeneratorInterface
443444
{
444445
// TODO: before creating an input validator, check if any validation rules are defined
445446
return $this->buildCallback(
@@ -874,7 +875,7 @@ private function buildTypeResolver(Callback $typeResolver): GeneratorInterface
874875
return $this->buildCallback($typeResolver, ['value', 'context', 'info']);
875876
}
876877

877-
protected function buildCallback(Callback $callback, array $argNames, ?callable $expressionBuilder = null): GeneratorInterface
878+
private function buildCallback(Callback $callback, array $argNames, ?callable $expressionBuilder = null): GeneratorInterface
878879
{
879880
if (null !== $callback->expression) {
880881
if (null === $expressionBuilder) {

0 commit comments

Comments
 (0)
Please sign in to comment.