Skip to content

Not sure where to ask questions. #13

@gdey

Description

@gdey

I'm sorry if this isn't the correct place, just point me to the correct place.

First off thank you for this bit of code.

I have a few questions as I'm exploring the ThreeLegged API's for the forge.

  1. I noticed that the tests under OAuth are still pointing to apprentice3d's repo. I believe this is an error. Would you be amenable to a pull request that fixes this?

  2. What is the reasoning behind *HubAPI3L's methods not being the same as HubAPI? I am unable to come up with a reason for GetHubs to be renamed to GetHubsThreeLegged. Having two different names to get hubs (this applies to other objects as well), make it difficult to swap between the two objects. I have an application where it would be useful to support both 2 and 3 legged auth depending on how the application is installed and called.

It seems to me for the ThreeLegged API that mirrors the TwoLegged one could have the same method name on the ThreeLegged v.s. the TwoLegged models. Then an Interface can be defined for getting hubs, projects, items, etc...

Thank you, for your time.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions