Merge pull request #114 from jackylamhk/fix/custom-resource-runtime

mnapoli · web-flow · commit ce52589da814 · 2025-12-05T15:36:40.000+01:00
fix: Ensure custom resource runtime is at least Node 18
diff --git a/lib/plugins/aws/custom-resources/index.js b/lib/plugins/aws/custom-resources/index.js
@@ -164,7 +164,8 @@ async function addCustomResourceToService(awsProvider, resourceName, iamRoleStat
 
   let runtimeVersion = 'nodejs24.x';
   const providerRuntime = awsProvider.getRuntime();
-  if (providerRuntime.startsWith('nodejs')) {
+  // AWS SDK v3 is only bundled with Node.js 18 and up
+  if (providerRuntime.startsWith('nodejs') && Number(providerRuntime.substring(6, 8)) >= 18) {
     runtimeVersion = providerRuntime;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,8 @@ async function addCustomResourceToService(awsProvider, resourceName, iamRoleStat`
`164`	`164`
`165`	`165`	`let runtimeVersion = 'nodejs24.x';`
`166`	`166`	`const providerRuntime = awsProvider.getRuntime();`
`167`		`- if (providerRuntime.startsWith('nodejs')) {`
	`167`	`+ // AWS SDK v3 is only bundled with Node.js 18 and up`
	`168`	`+ if (providerRuntime.startsWith('nodejs') && Number(providerRuntime.substring(6, 8)) >= 18) {`
`168`	`169`	`runtimeVersion = providerRuntime;`
`169`	`170`	`}`
`170`	`171`