Merge pull request #100 from gleb-centrica/update_nodejs_custom_resource

Fix: update nodejs version to 22.x for custom resource lambdas

Author: mnapoli

lib/plugins/aws/custom-resources/index.js

@@ -162,7 +162,7 @@ async function addCustomResourceToService(awsProvider, resourceName, iamRoleStat
     });
   }
 
-  let runtimeVersion = 'nodejs18.x';
+  let runtimeVersion = 'nodejs22.x';
   const providerRuntime = awsProvider.getRuntime();
   if (providerRuntime.startsWith('nodejs')) {
     runtimeVersion = providerRuntime;

test/unit/lib/plugins/aws/custom-resources/index.test.js

@@ -428,6 +428,81 @@ describe('test/unit/lib/plugins/aws/customResources/index.test.js', () => {
     expect(properties.FunctionName.endsWith('testing-custom-resource-apigw-cw-role')).to.be.true;
   });
 
+  it('falls back to nodejs22 runtime for CW custom resource if provider runtime is not nodejs ', async () => {
+    const { cfTemplate } = await runServerless({
+      fixture: 'api-gateway',
+      command: 'package',
+      options: { stage: 'testing' },
+      configExt: {
+        provider: {
+          runtime: 'python3.12',
+          logs: {
+            restApi: true,
+          },
+        },
+      },
+    });
+
+    const properties =
+      cfTemplate.Resources.CustomDashresourceDashapigwDashcwDashroleLambdaFunction.Properties;
+    expect(properties.Runtime).to.equal('nodejs22.x');
+  });
+
+  it('falls back to nodejs22 runtime for Cognito UP custom resource if provider runtime is not nodejs ', async () => {
+    const { cfTemplate } = await runServerless({
+      fixture: 'cognito-user-pool',
+      command: 'package',
+      options: { stage: 'testing' },
+      configExt: {
+        provider: {
+          runtime: 'python3.12',
+        },
+      },
+    });
+
+    const properties =
+      cfTemplate.Resources.CustomDashresourceDashexistingDashcupLambdaFunction.Properties;
+    expect(properties.Runtime).to.equal('nodejs22.x');
+  });
+
+  it('falls back to nodejs22 runtime for Event Bridge [LEGACY] custom resource if provider runtime is not nodejs ', async () => {
+    const { cfTemplate } = await runServerless({
+      fixture: 'event-bridge',
+      command: 'package',
+      options: { stage: 'testing' },
+      configExt: {
+        disabledDeprecations: ['AWS_EVENT_BRIDGE_CUSTOM_RESOURCE_LEGACY_OPT_IN'],
+        provider: {
+          runtime: 'python3.12',
+          eventBridge: {
+            useCloudFormation: false,
+          },
+        },
+      },
+    });
+
+    const properties =
+      cfTemplate.Resources.CustomDashresourceDasheventDashbridgeLambdaFunction.Properties;
+    expect(properties.Runtime).to.equal('nodejs22.x');
+  });
+
+  it('falls back to nodejs22 runtime for S3 custom resource if provider runtime is not nodejs ', async () => {
+    const { cfTemplate } = await runServerless({
+      fixture: 's3',
+      command: 'package',
+      options: { stage: 'testing' },
+      configExt: {
+        provider: {
+          runtime: 'python3.12',
+        },
+      },
+    });
+
+    const properties =
+      cfTemplate.Resources.CustomDashresourceDashexistingDashs3LambdaFunction.Properties;
+    expect(properties.Runtime).to.equal('nodejs22.x');
+  });
+
   it('correctly takes stage from config into account when constructing apiGatewayCloudWatchRole resource', async () => {
     const { cfTemplate } = await runServerless({
       fixture: 'api-gateway',