Dumping Ground Ticket

[FelixMZ2018]

A ticket for all helpers that make life easier

Workflow.updateAndReturnNewElement(updateFn(updateFnParams)){
returns {workflow: newWorkflow, element: newlyAddedElement}
}
monkey patch:

  static updateWorkflowAndReturnChangedElementId(workflow, fn) {
    const existingIds = GraphTools.getAllElementIds(workflow)
    const newWorkflow = fn(this, arguments)
    const newIds = GraphTools.getAllElementIds(newWorkflow)
    if (existingIds.length < newIds.length) {
      return {
        workflow: newWorkflow,
        changedId: newIds.find(id => !existingIds.includes(id)),
      }
    }
    if (existingIds.length > newIds.length) {
      return {
        workflow: newWorkflow,
        changedId: existingIds.find(id => !newIds.includes(id)),
      }
    }
  }

static validateFlow(workflow,flowId){
}

Workflow.validate does not work when gradually building a workflow, (e.g adding a new phase then connecting one end at a time

[vdiezel]

The first request makes sense. The second one is more tricky: A half-baked connection should be invalid. I think the consumer of the API has to make sure to call it only when the second connection happened. I hope there is a callback for that.

[vdiezel]

For the helper method, I wonder if simply using the "get last element" is fair enough for our use case. Relying on the order is dangerous, but I think it might be just fine in these cases. In case of an update, you already know the ID of the element, so you only need the ID when you add an element. Because we always append at the end, it will work.