Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you want the osmosis crate? #41

Open
tony-iqlusion opened this issue Sep 10, 2022 · 1 comment
Open

Do you want the osmosis crate? #41

tony-iqlusion opened this issue Sep 10, 2022 · 1 comment

Comments

@tony-iqlusion
Copy link

Hi, I own this crate: https://crates.io/crates/osmosis

Would you like it? You're welcome to it.

We also have an open PR to add an osmosis-proto crate to the cosmos-rust repo: cosmos/cosmos-rust#288

Curious what you think about that. I think there's some value in having a monorepo for the Protobuf crates so they can follow a common set of conventions that can evolve together. However, if you have plans for a Protobuf crate, you're also welcome to the osmosis-proto crate and maybe the work in that PR can be opened here instead.

@iboss-ptk
Copy link
Collaborator

Hi @tony-iqlusion.

For osmosis crate, that would be awesome to have! Thanks you for the offer!

For later point about monorepo, it is open for discussion. I have been pondering about it as well. Maybe the generated crate itself can live in different repo due to custom needs and management, but for proto-build, the work we enriching it could become general / customizable tool for generating proto to suites any chain's need. That I think we could contribute back to cosmos-rust. Let me know you thoughts.

The focus here for the moment is to make the type generated works for cosmwasm, and the current our cosmos-sdk is a forked one as well, so we potentially generate cosmos-sdk's type on our own, but let me know if you have better idea on repo management that benefits everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants