Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open links in new tab/window / cmd+click #17

Open
tordans opened this issue Feb 22, 2023 · 0 comments
Open

Open links in new tab/window / cmd+click #17

tordans opened this issue Feb 22, 2023 · 0 comments

Comments

@tordans
Copy link
Contributor

tordans commented Feb 22, 2023

This is a more general ticket for #12.

The links on https://osmberlin.github.io/osm-tag-updater/#/ "Option 1: Load tags from OSM way, Option 2: Manually input tags" do not work when using cmd+click or "open in new window/tab". I assume all other links do not as well, except for the one I explicitly fixed in #12 (which does nothing on cmd+click, but at least it does not show a 404).

Open for suggestions on how to solve this with React Location and Github Pages.

One issue is, that Github pages does not support rewrite rules. => And one solution would be to use Nelitfy/Vercel for deployment/hosting.

Another approach might be to update to Tanstack Router (beta).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant