Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with the update_version_check.py file #364

Open
prabhakaryadav2003 opened this issue Jan 12, 2025 · 0 comments
Open

Issue with the update_version_check.py file #364

prabhakaryadav2003 opened this issue Jan 12, 2025 · 0 comments

Comments

@prabhakaryadav2003
Copy link

prabhakaryadav2003 commented Jan 12, 2025

Description:

The Update class in the file contains a method notifi which uses the github url to fetch Readme.md
The method searches for regular expression match of here:

 match = re.search(r'Download the latest release version (\S+)', decoded_line)

The match will always be None as there is no such line in the Readme.md file, it was removed in this commit

Suggestion:

Instead of using the Readme.md file we could directly use the __version.py of the repository, and perform a regex search to fetch the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant