@@ -32,19 +32,29 @@ MAKE_SUB_CALL := make CONTAINER_EXECUTABLE="$(CONTAINER_EXECUTABLE)"
3232# osbuild is indirectly used by osbuild-composer
3333# but we'll mention it here too for better error messages and usability
3434COMMON_SRC_DEPS_NAMES := osbuild osbuild-composer pulp-client community-gateway
35- COMMON_SRC_DEPS_ORIGIN := $(addprefix $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) ,$(COMMON_SRC_DEPS_NAMES ) )
35+ COMMON_SRC_DEPS_ORIGIN := $(addprefix $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) / ,$(COMMON_SRC_DEPS_NAMES ) )
3636
3737ONPREM_SRC_DEPS_NAMES := weldr-client
38- ONPREM_SRC_DEPS_ORIGIN := $(addprefix $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) ,$(ONPREM_SRC_DEPS_NAMES ) )
38+ ONPREM_SRC_DEPS_ORIGIN := $(addprefix $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) / ,$(ONPREM_SRC_DEPS_NAMES ) )
3939
40- SERVICE_SRC_DEPS_NAMES := image-builder image-builder-frontend
41- SERVICE_SRC_DEPS_ORIGIN := $(addprefix $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) ,$(SERVICE_SRC_DEPS_NAMES ) )
40+ SERVICE_SRC_DEPS_NAMES := image-builder-crc image-builder-frontend
41+ SERVICE_SRC_DEPS_ORIGIN := $(addprefix $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) / ,$(SERVICE_SRC_DEPS_NAMES ) )
4242
4343# should be set if we are already sudo - otherwise we set to "whoami"
4444SUDO_USER ?= $(shell whoami)
4545
46- $(COMMON_SRC_DEPS_ORIGIN ) $(SERVICE_SRC_DEPS_ORIGIN ) $(ONPREM_SRC_DEPS_ORIGIN ) :
47- @for DIR in $@ ; do if ! [ -d $$ DIR ]; then echo " Please checkout $$ DIR so it is available at $$ DIR" ; exit 1; fi ; done
46+ ALL_REQUIRED_DIRS := $(COMMON_SRC_DEPS_ORIGIN ) $(SERVICE_SRC_DEPS_ORIGIN ) $(ONPREM_SRC_DEPS_ORIGIN )
47+
48+ $(ALL_REQUIRED_DIRS ) :
49+ @if ! [ -d $@ ]; then \
50+ echo " Please checkout '$$ (basename $@ )' so it is available at $$ (readlink -f $@ )" ; \
51+ echo " I expect a structure like this:" ; \
52+ echo " $$ (readlink -f $( SRC_DEPS_EXTERNAL_CHECKOUT_DIR) )" ; \
53+ for REPO in $( ALL_REQUIRED_DIRS) ; do \
54+ echo " ├── $$ (basename $$ REPO)" ; \
55+ done ; \
56+ exit 1; \
57+ fi ;
4858
4959COMPARE_TO_BRANCH ?= origin/main
5060
@@ -57,15 +67,19 @@ ALL_SCRATCH_DIRS := $(addprefix $(SCRATCH_DIR)/,$(COMMON_DIR) $(CLI_DIRS) $(DATA
5767
5868OSBUILD_DIR ?= $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) /osbuild
5969OSBUILD_COMPOSER_DIR ?= $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) /osbuild-composer
70+ IMAGE_BUILDER_CRC_DIR ?= $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) /image-builder-crc
71+ IMAGE_BUILDER_FRONTEND_DIR ?= $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) /image-builder-frontend
6072
6173.PHONY : service_containers
62- service_containers :
74+ service_containers : service_sub_make_backend
6375 make -C $(OSBUILD_DIR ) -f $(GETTING_STARTED_DIR ) /repos/osbuild/Makefile.getting-started container.dev
6476 make -C $(OSBUILD_COMPOSER_DIR ) -f $(GETTING_STARTED_DIR ) /repos/osbuild-composer/Makefile.getting-started container.dev
77+
6578
6679clean :
6780 make -C $(OSBUILD_DIR ) -f $(GETTING_STARTED_DIR ) /repos/osbuild/Makefile.getting-started clean.dev
6881 make -C $(OSBUILD_COMPOSER_DIR ) -f $(GETTING_STARTED_DIR ) /repos/osbuild-composer/Makefile.getting-started clean.dev
82+ make -C $(IMAGE_BUILDER_CRC_DIR ) -f $(GETTING_STARTED_DIR ) /repos/image-builder-crc/Makefile.getting-started clean.dev
6983
7084# internal rule for sub-calls
7185# NOTE: This chowns all directories back - as we expect to run partly as root
@@ -76,15 +90,17 @@ common_sub_makes:
7690 @echo " At least for podman the password as already needed now"
7791
7892 # creating container image from osbuild as a basis for worker
79- $(MAKE_SUB_CALL ) -C $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR) osbuild-composer container_worker.dev container_composer .dev
93+ make -C $(OSBUILD_COMPOSER_DIR ) -f $(GETTING_STARTED_DIR)/repos/ osbuild-composer/Makefile.getting-started container .dev
8094
8195.PHONY : service_sub_make_backend
8296service_sub_make_backend :
83- $(MAKE_SUB_CALL ) -C $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) image-builder container.dev
97+ make -C $(OSBUILD_DIR ) -f $(GETTING_STARTED_DIR ) /repos/osbuild/Makefile.getting-started container.dev
98+ make -C $(OSBUILD_COMPOSER_DIR ) -f $(GETTING_STARTED_DIR ) /repos/osbuild-composer/Makefile.getting-started container.dev
99+ make -C $(IMAGE_BUILDER_CRC_DIR ) -f $(GETTING_STARTED_DIR ) /repos/image-builder-crc/Makefile.getting-started container.dev
84100
85101.PHONY : service_sub_make_frontend
86102service_sub_make_frontend :
87- $( MAKE_SUB_CALL ) -C $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) image-builder-frontend container.dev
103+ make -C $( IMAGE_BUILDER_CRC_DIR ) -f $(GETTING_STARTED_DIR ) /repos/ image-builder-frontend/Makefile.getting-started container.dev
88104
89105.PHONY : service_sub_make_cleanup
90106service_sub_make_cleanup :
0 commit comments