@@ -32,19 +32,37 @@ MAKE_SUB_CALL := make CONTAINER_EXECUTABLE="$(CONTAINER_EXECUTABLE)"
3232# osbuild is indirectly used by osbuild-composer
3333# but we'll mention it here too for better error messages and usability
3434COMMON_SRC_DEPS_NAMES := osbuild osbuild-composer pulp-client community-gateway
35- COMMON_SRC_DEPS_ORIGIN := $(addprefix $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) ,$(COMMON_SRC_DEPS_NAMES ) )
35+ COMMON_SRC_DEPS_ORIGIN := $(addprefix $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) / ,$(COMMON_SRC_DEPS_NAMES ) )
3636
3737ONPREM_SRC_DEPS_NAMES := weldr-client
38- ONPREM_SRC_DEPS_ORIGIN := $(addprefix $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) ,$(ONPREM_SRC_DEPS_NAMES ) )
38+ ONPREM_SRC_DEPS_ORIGIN := $(addprefix $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) / ,$(ONPREM_SRC_DEPS_NAMES ) )
3939
40- SERVICE_SRC_DEPS_NAMES := image-builder image-builder-frontend
41- SERVICE_SRC_DEPS_ORIGIN := $(addprefix $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) ,$(SERVICE_SRC_DEPS_NAMES ) )
40+ SERVICE_SRC_DEPS_NAMES := image-builder-crc image-builder-frontend
41+ SERVICE_SRC_DEPS_ORIGIN := $(addprefix $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) / ,$(SERVICE_SRC_DEPS_NAMES ) )
4242
4343# should be set if we are already sudo - otherwise we set to "whoami"
4444SUDO_USER ?= $(shell whoami)
4545
46- $(COMMON_SRC_DEPS_ORIGIN ) $(SERVICE_SRC_DEPS_ORIGIN ) $(ONPREM_SRC_DEPS_ORIGIN ) :
47- @for DIR in $@ ; do if ! [ -d $$ DIR ]; then echo " Please checkout $$ DIR so it is available at $$ DIR" ; exit 1; fi ; done
46+ ALL_REQUIRED_DIRS := $(COMMON_SRC_DEPS_ORIGIN ) $(SERVICE_SRC_DEPS_ORIGIN ) $(ONPREM_SRC_DEPS_ORIGIN )
47+
48+ $(ALL_REQUIRED_DIRS ) :
49+ @if ! [ -d $@ ]; then \
50+ echo " Please checkout '$$ (basename $@ )' so it is available at $$ (readlink -f $@ )" ; \
51+ echo " I expect a structure like this:" ; \
52+ echo " $$ (readlink -f $( SRC_DEPS_EXTERNAL_CHECKOUT_DIR) )" ; \
53+ TOTAL=$$(echo $(ALL_REQUIRED_DIRS ) | wc -w ) ; \
54+ COUNT=1; \
55+ for REPO in $( ALL_REQUIRED_DIRS) ; do \
56+ if [ $$ COUNT -eq $$ TOTAL ]; then \
57+ PREFIX=" └──" ; \
58+ else \
59+ PREFIX=" ├──" ; \
60+ fi ; \
61+ echo " $$ PREFIX $$ (basename $$ REPO)" ; \
62+ COUNT=$$((COUNT + 1 ) ); \
63+ done ; \
64+ exit 1; \
65+ fi ;
4866
4967COMPARE_TO_BRANCH ?= origin/main
5068
@@ -57,16 +75,14 @@ ALL_SCRATCH_DIRS := $(addprefix $(SCRATCH_DIR)/,$(COMMON_DIR) $(CLI_DIRS) $(DATA
5775
5876OSBUILD_DIR ?= $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) /osbuild
5977OSBUILD_COMPOSER_DIR ?= $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) /osbuild-composer
78+ IMAGE_BUILDER_CRC_DIR ?= $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) /image-builder-crc
79+ IMAGE_BUILDER_FRONTEND_DIR ?= $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) /image-builder-frontend
6080
6181.PHONY : service_containers
62- service_containers :
82+ service_containers : service_sub_make_backend
6383 make -C $(OSBUILD_DIR ) -f $(GETTING_STARTED_DIR ) /repos/osbuild/Makefile.getting-started container.dev
6484 make -C $(OSBUILD_COMPOSER_DIR ) -f $(GETTING_STARTED_DIR ) /repos/osbuild-composer/Makefile.getting-started container.dev
6585
66- clean :
67- make -C $(OSBUILD_DIR ) -f $(GETTING_STARTED_DIR ) /repos/osbuild/Makefile.getting-started clean.dev
68- make -C $(OSBUILD_COMPOSER_DIR ) -f $(GETTING_STARTED_DIR ) /repos/osbuild-composer/Makefile.getting-started clean.dev
69-
7086# internal rule for sub-calls
7187# NOTE: This chowns all directories back - as we expect to run partly as root
7288# also we "git fetch origin" to get the current state!
@@ -76,15 +92,17 @@ common_sub_makes:
7692 @echo " At least for podman the password as already needed now"
7793
7894 # creating container image from osbuild as a basis for worker
79- $(MAKE_SUB_CALL ) -C $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR) osbuild-composer container_worker.dev container_composer .dev
95+ make -C $(OSBUILD_COMPOSER_DIR ) -f $(GETTING_STARTED_DIR)/repos/ osbuild-composer/Makefile.getting-started container .dev
8096
8197.PHONY : service_sub_make_backend
8298service_sub_make_backend :
83- $(MAKE_SUB_CALL ) -C $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) image-builder container.dev
99+ make -C $(OSBUILD_DIR ) -f $(GETTING_STARTED_DIR ) /repos/osbuild/Makefile.getting-started container.dev
100+ make -C $(OSBUILD_COMPOSER_DIR ) -f $(GETTING_STARTED_DIR ) /repos/osbuild-composer/Makefile.getting-started container.dev
101+ make -C $(IMAGE_BUILDER_CRC_DIR ) -f $(GETTING_STARTED_DIR ) /repos/image-builder-crc/Makefile.getting-started container.dev
84102
85103.PHONY : service_sub_make_frontend
86104service_sub_make_frontend :
87- $( MAKE_SUB_CALL ) -C $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) image-builder-frontend container.dev
105+ make -C $( IMAGE_BUILDER_CRC_DIR ) -f $(GETTING_STARTED_DIR ) /repos/ image-builder-frontend/Makefile.getting-started container.dev
88106
89107.PHONY : service_sub_make_cleanup
90108service_sub_make_cleanup :
@@ -101,7 +119,7 @@ service_sub_makes: service_sub_make_backend service_sub_make_frontend service_su
101119.PHONY : onprem_sub_makes
102120onprem_sub_makes :
103121 # building the cli
104- $(MAKE_SUB_CALL ) -C $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) weldr-client container.dev
122+ $(MAKE_SUB_CALL ) -C $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) / weldr-client container.dev
105123 @for DIR in $(COMMON_SRC_DEPS_ORIGIN ) $(ONPREM_SRC_DEPS_ORIGIN ) ; do echo " Giving directory permissions in '$$ DIR' back to '$( SUDO_USER) '" ; chown -R $(SUDO_USER ) : $$ DIR || sudo chown -R $(SUDO_USER ) : $$ DIR; done
106124 @echo " Your current versions are (comparing to origin/main):"
107125 bash -c ' ./tools/git_stack.sh'
@@ -133,14 +151,17 @@ $(ALL_SCRATCH_DIRS):
133151.PHONY : wipe_config
134152wipe_config :
135153 sudo rm -rf $(SCRATCH_DIR ) /$(COMMON_DIR )
136- rm -f $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) image-builder-frontend/node_modules/.cache/webpack-dev-server/server.pem
154+ rm -f $(SRC_DEPS_EXTERNAL_CHECKOUT_DIR ) / image-builder-frontend/node_modules/.cache/webpack-dev-server/server.pem
137155
138156.PHONY : clean
139- clean_old : prune_service prune_onprem wipe_config
157+ clean : prune_service prune_onprem wipe_config
140158 rm -f service_images_built.info
141159 rm -f onprem_images_built.info
142- rm -rf $(SCRATCH_DIR ) || (echo " Trying as root" ; sudo rm -rf $( SCRATCH_DIR) )
143- for DIR in $( COMMON_SRC_DEPS_ORIGIN) $( SERVICE_SRC_DEPS_ORIGIN) $( ONPREM_SRC_DEPS_ORIGIN) ; do $( MAKE_SUB_CALL) -C $$ DIR clean; done
160+ rm -rf $(SCRATCH_DIR ) 2> /dev/null || (echo " Trying as root" ; sudo rm -rf $( SCRATCH_DIR) )
161+ make -C $(OSBUILD_DIR ) -f $(GETTING_STARTED_DIR ) /repos/osbuild/Makefile.getting-started clean.dev
162+ make -C $(OSBUILD_COMPOSER_DIR ) -f $(GETTING_STARTED_DIR ) /repos/osbuild-composer/Makefile.getting-started clean.dev
163+ make -C $(IMAGE_BUILDER_CRC_DIR ) -f $(GETTING_STARTED_DIR ) /repos/image-builder-crc/Makefile.getting-started clean.dev
164+
144165 $(CONTAINER_COMPOSE_EXECUTABLE) -f service/docker-compose.yml down --volumes
145166 $(CONTAINER_COMPOSE_EXECUTABLE) -f service/docker-compose.yml rm --volumes
146167 $(CONTAINER_COMPOSE_EXECUTABLE) -f service/docker-compose-onprem.yml down --volumes
0 commit comments