4992: Cleaned up how exceptions are mapped to http exceptions

Author: tuj

config/packages/api_platform.yaml

@@ -50,3 +50,22 @@ api_platform:
             email: [email protected]
         license:
             name: MIT
+
+    # @see https://api-platform.com/docs/core/errors/#exception-to-status-configuration-using-symfony
+    exception_to_status:
+        # The 4 following handlers are registered by default, keep those lines to prevent unexpected side effects
+        Symfony\Component\Serializer\Exception\ExceptionInterface: 400 # Use a raw status code (recommended)
+        ApiPlatform\Exception\InvalidArgumentException: !php/const Symfony\Component\HttpFoundation\Response::HTTP_BAD_REQUEST
+        ApiPlatform\ParameterValidator\Exception\ValidationExceptionInterface: 400
+        Doctrine\ORM\OptimisticLockException: 409
+
+        # Validation exception
+        ApiPlatform\Validator\Exception\ValidationException: !php/const Symfony\Component\HttpFoundation\Response::HTTP_UNPROCESSABLE_ENTITY
+
+        # App exception mappings
+        App\Exceptions\BadRequestException: 400
+        App\Exceptions\ForbiddenException: 403
+        App\Exceptions\NotFoundException: 404
+        App\Exceptions\NotAcceptableException: 406
+        App\Exceptions\ConflictException: 409
+        App\Exceptions\TooManyRequestsException: 429

public/fixture/resources.json

@@ -0,0 +1,6 @@
+[
+    {
+        "ResourceMail": "[email protected]",
+        "allowInstantBooking": "True"
+    }
+]

src/Controller/InteractiveController.php

@@ -6,15 +6,16 @@
 
 use App\Entity\ScreenUser;
 use App\Entity\Tenant\Slide;
-use App\Entity\User;
-use App\Exceptions\InteractiveSlideException;
+use App\Exceptions\BadRequestException;
+use App\Exceptions\ConflictException;
+use App\Exceptions\NotAcceptableException;
+use App\Exceptions\TooManyRequestsException;
 use App\Service\InteractiveSlideService;
 use Symfony\Bundle\SecurityBundle\Security;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpKernel\Attribute\AsController;
-use Symfony\Component\HttpKernel\Exception\HttpException;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
+use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
 
 #[AsController]
 final readonly class InteractiveController
@@ -24,27 +25,27 @@ public function __construct(
         private Security $security,
     ) {}
 
+    /**
+     * @throws ConflictException
+     * @throws BadRequestException
+     * @throws NotAcceptableException
+     * @throws TooManyRequestsException
+     */
     public function __invoke(Request $request, Slide $slide): JsonResponse
     {
-        $requestBody = $request->toArray();
+        $user = $this->security->getUser();
 
-        try {
-            $interactionRequest = $this->interactiveSlideService->parseRequestBody($requestBody);
-        } catch (InteractiveSlideException $e) {
-            throw new HttpException($e->getCode(), $e->getMessage());
+        if (!($user instanceof ScreenUser)) {
+            throw new AccessDeniedHttpException('Only screen user can perform action.');
         }
 
-        $user = $this->security->getUser();
+        $tenant = $user->getActiveTenant();
 
-        if (!($user instanceof User || $user instanceof ScreenUser)) {
-            throw new NotFoundHttpException('User not found');
-        }
+        $requestBody = $request->toArray();
 
-        try {
-            $actionResult = $this->interactiveSlideService->performAction($user, $slide, $interactionRequest);
-        } catch (InteractiveSlideException $e) {
-            throw new HttpException($e->getCode(), $e->getMessage());
-        }
+        $interactionRequest = $this->interactiveSlideService->parseRequestBody($requestBody);
+
+        $actionResult = $this->interactiveSlideService->performAction($tenant, $slide, $interactionRequest);
 
         return new JsonResponse($actionResult);
     }

src/Entity/Tenant/InteractiveSlide.php …Entity/Tenant/InteractiveSlideConfig.phpsrc/Entity/Tenant/InteractiveSlide.php renamed to src/Entity/Tenant/InteractiveSlideConfig.php src/Entity/Tenant/InteractiveSlide.php renamed to src/Entity/Tenant/InteractiveSlideConfig.php

@@ -9,7 +9,8 @@
 use Symfony\Component\Serializer\Annotation\Ignore;
 
 #[ORM\Entity(repositoryClass: InteractiveSlideRepository::class)]
-class InteractiveSlide extends AbstractTenantScopedEntity
+#[ORM\Table(name: "interactive_slide")]
+class InteractiveSlideConfig extends AbstractTenantScopedEntity
 {
     #[Ignore]
     #[ORM\Column(nullable: true)]

src/Exceptions/ForbiddenException.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace App\Exceptions;
+
+class ForbiddenException extends \Exception
+{
+
+}

src/Exceptions/InteractiveSlideException.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace App\Exceptions;
+
+class NotAcceptableException extends \Exception
+{
+
+}

src/Exceptions/NotAcceptableException.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace App\Exceptions;
+
+class TooManyRequestsException extends \Exception
+{
+
+}