Skip to content

Commit 0ec4ee4

Browse files
committed
4680: Fixed documentation and exception messages
1 parent 7784100 commit 0ec4ee4

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

public/fixture/resources.json

Lines changed: 0 additions & 6 deletions
This file was deleted.

src/InteractiveSlide/InstantBook.php

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,18 +59,20 @@ public function __construct(
5959

6060
public function getConfigOptions(): array
6161
{
62+
// All secrets are retrieved from the KeyVault. Therefore, the input for the different configurations are the
63+
// keys into the KeyVault where the values can be retrieved.
6264
return [
6365
'tenantId' => [
6466
'required' => true,
65-
'description' => 'The key in the KeyVault for the tenant id of the App',
67+
'description' => 'The key in the KeyVault for the tenant id of the Microsoft Graph App',
6668
],
6769
'clientId' => [
6870
'required' => true,
69-
'description' => 'The key in the KeyVault for the client id of the App',
71+
'description' => 'The key in the KeyVault for the client id of the Microsoft Graph App',
7072
],
7173
'username' => [
7274
'required' => true,
73-
'description' => 'The key in the KeyVault for the Microsoft Graph username that should perform the action.',
75+
'description' => 'The key in the KeyVault for the username that should perform the action.',
7476
],
7577
'password' => [
7678
'required' => true,
@@ -129,7 +131,7 @@ private function getToken(Tenant $tenant, InteractiveSlide $interactive): string
129131
$configuration = $interactive->getConfiguration();
130132

131133
if (null === $configuration) {
132-
throw new BadRequestHttpException('Interactive no configuration');
134+
throw new BadRequestHttpException('InteractiveSlide has no configuration');
133135
}
134136

135137
return $this->interactiveSlideCache->get(
@@ -166,7 +168,7 @@ function (CacheItemInterface $item) use ($slide, $resource, $interactionRequest)
166168
$interactive = $this->interactiveService->getInteractiveSlide($tenant, $interactionRequest->implementationClass);
167169

168170
if (null === $interactive) {
169-
throw new \Exception('InteractiveNotFound');
171+
throw new \Exception('InteractiveSlide not found');
170172
}
171173

172174
// Optional limiting of available resources.
@@ -175,7 +177,7 @@ function (CacheItemInterface $item) use ($slide, $resource, $interactionRequest)
175177
$feed = $slide->getFeed();
176178

177179
if (null === $feed) {
178-
throw new \Exception('Slide.feed not set.');
180+
throw new \Exception('Slide feed not set.');
179181
}
180182

181183
if (!in_array($resource, $feed->getConfiguration()['resources'] ?? [])) {

0 commit comments

Comments
 (0)