Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using scenarios, don't throw until test is finished. #175

Open
vectro opened this issue Sep 17, 2024 · 1 comment
Open

When using scenarios, don't throw until test is finished. #175

vectro opened this issue Sep 17, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@vectro
Copy link

vectro commented Sep 17, 2024

If a test has multiple scenarios, we currently throw an exception the first time we call toMatchSnapshot() with different data. But then we miss the opportunity to update the rest of the scenarios in the .snap.debug file.

It would be better to let the test finish, and then raise if necessary with all differences together.

@jackmatt2
Copy link
Member

Yes - agree that this is the preferred behaviour. Would accept a PR implementing this.

@jackmatt2 jackmatt2 added the enhancement New feature or request label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants