Euphony
테스트케이스가 실패하지 않았는데 빌드에 실패하는 문제 #63
-
|
테스트케이스가 실패하지 않았는데 빌드에 실패하는 문제가 발생하여 질문드립니다. TestParamType("가", "ac00")을 주고 인위적으로 정답을 만들기 위해 추가 정보 TEST_P(UTF16CharsetTestFixture, EncodingTest)
{
openCharset();
std::string source;
std::string expectedResult;
std::tie(source, expectedResult) = GetParam();
HexVector actualResult = charset->encode(source);
EXPECT_EQ(actualResult.toString(), expectedResult);
}Build Output
Sourceeuphony/src/main/cpp/core/UTF16Charset.h #ifndef EUPHONY_UTF16CHARSET_H
#define EUPHONY_UTF16CHARSET_H
#include "Charset.h"
namespace Euphony {
class UTF16Charset : public Charset {
public:
UTF16Charset() = default;
~UTF16Charset() = default;
HexVector encode(std::string src);
std::string decode(const HexVector &src);
};
}
#endif //EUPHONY_UTF16CHARSET_Heuphony/src/main/cpp/core/source/UTF16Charset.cpp #include "../UTF16Charset.h"
#include <sstream>
#include <iomanip>
using namespace Euphony;
HexVector UTF16Charset::encode(std::string src) {
std::vector<u_int8_t> source = std::vector<u_int8_t> { 0xa, 0xc, 0x0, 0x0 };
HexVector result = HexVector(source);
return result;
}
std::string UTF16Charset::decode(const HexVector &src) {
std::string result;
std::string stringSrc = src.toString();
result = "가";
return "가";
}euphony/src/main/cpp/tests/utf16CharsetTest.cpp #include <gtest/gtest.h>
#include <Definitions.h>
#include <UTF16Charset.h>
#include <tuple>
using namespace Euphony;
typedef std::tuple<std::string, std::string> TestParamType;
class UTF16CharsetTestFixture : public ::testing::TestWithParam<TestParamType> {
public:
void openCharset() {
EXPECT_EQ(charset, nullptr);
charset = new UTF16Charset();
ASSERT_NE(charset, nullptr);
}
Charset* charset = nullptr;
};
TEST_P(UTF16CharsetTestFixture, EncodingTest)
{
openCharset();
std::string source;
std::string expectedResult;
std::tie(source, expectedResult) = GetParam();
HexVector actualResult = charset->encode(source);
EXPECT_EQ(actualResult.toString(), expectedResult);
}
TEST_P(UTF16CharsetTestFixture, DecodingTest)
{
openCharset();
std::string source;
std::string expectedResult;
std::tie(expectedResult, source) = GetParam();
HexVector hv = HexVector(source);
std::string actualResult = charset->decode(hv);
EXPECT_EQ(actualResult, expectedResult);
}
INSTANTIATE_TEST_CASE_P(
ChrasetDecodingTestSuite,
UTF16CharsetTestFixture,
::testing::Values(
TestParamType("가", "ac00")
)); |
Beta Was this translation helpful? Give feedback.
Replies: 8 comments 80 replies
-
|
문자 그대로 gtest 실패가 아닌 ninja의 빌드 실패인데 잘 모르겠네요.. |
Beta Was this translation helpful? Give feedback.
-
|
넵 CMake도 같이 올려드릴게요. CMakeLists.txt cmake_minimum_required(VERSION 3.4.1)
project(euphony
VERSION 0.8)
# Legacy JNI
set(LEGACY_SRC
arms/kiss_fft.c
arms/kiss_fftr.c
native-legacy.cpp
)
find_library( log-lib log )
add_library( native-legacy SHARED ${LEGACY_SRC} )
target_compile_definitions(native-legacy PUBLIC FIXED_POINT=16)
target_link_libraries(
native-legacy
${log-lib}
-fopenmp
-static-openmp
)
# Rearchitectured Euphony Native
set(EUPHONY_SRC
arms/kiss_fft.c
arms/kiss_fftr.c
core/source/AudioStreamCallback.cpp
core/source/ASCIICharset.cpp
core/source/UTF16Charset.cpp
core/source/Base2.cpp
core/source/Base16.cpp
core/source/Base16Exception.cpp
core/source/DefaultCharset.cpp
core/source/EuPIOscillator.cpp
core/source/EuPIRenderer.cpp
core/source/FFTModel.cpp
core/source/FFTProcessor.cpp
core/source/FSK.cpp
core/source/HexVector.cpp
core/source/Packet.cpp
core/source/PacketBuilder.cpp
core/source/PacketErrorDetector.cpp
core/source/TxEngine.cpp
core/source/Wave.cpp
core/source/WaveBuilder.cpp
core/source/WaveRenderer.cpp
native-connector.cpp
)
set(EUPHONY_HDR core)
set(DEBUG_HELPER debug-helper)
set(DEBUG_HELPER_SRC debug-helper/Trace.cpp)
set(SL_HEADERS arms/sl-headers)
include_directories( ${EUPHONY_HDR} ${SL_HEADERS} ${DEBUG_HELPER})
add_library(euphony SHARED ${EUPHONY_SRC} ${DEBUG_HELPER_SRC})
target_compile_definitions(euphony PUBLIC FIXED_POINT=16)
find_package(
oboe REQUIRED CONFIG
)
target_link_libraries(
euphony
${log-lib}
OpenSLES
oboe::oboe
-fopenmp
-static-openmp
)
# for c++ unit-test (gtest)
add_subdirectory(tests)tests/CMakeLists.txt cmake_minimum_required(VERSION 3.4.1)
set(TEST_EUPHONY testEuphony)
# Include GoogleTest library
set (GOOGLETEST_ROOT ${ANDROID_NDK}/sources/third_party/googletest)
add_library (gtest STATIC ${GOOGLETEST_ROOT}/src/gtest_main.cc ${GOOGLETEST_ROOT}/src/gtest-all.cc)
target_include_directories (gtest PRIVATE ${GOOGLETEST_ROOT})
target_include_directories (gtest PUBLIC ${GOOGLETEST_ROOT}/include)
add_executable(
${TEST_EUPHONY}
asciiCharsetTest.cpp
utf16CharsetTest.cpp
base2Test.cpp
base16Test.cpp
defaultCharsetTest.cpp
FFTTest.cpp
FSKTest.cpp
hexVectorTest.cpp
packetTest.cpp
packetBuilderTest.cpp
packetErrorDetectorTest.cpp
packetWithFSKTest.cpp
waveTest.cpp
waveBuilderTest.cpp
waveRendererTest.cpp
)
target_link_libraries(${TEST_EUPHONY} PUBLIC euphony gtest)
set(TARGET_TEST_DIR /data/local/tmp/${TEST_EUPHONY}) # Directory on device to push tests.
set(TARGET_TEST_LIB_DIR ${TARGET_TEST_DIR}/${ANDROID_ABI})
set(LIBCPP_SHARED_PATH ${ANDROID_NDK}/sources/cxx-stl/llvm-libc++/libs/${ANDROID_ABI}/libc++_shared.so)
get_target_property( OBOE_LIBRARY_PATH oboe::oboe IMPORTED_LOCATION)
find_program(ADB NAMES adb PATHS ${ANDROID_SDK_ROOT}/platform-tools) # Verified to be working on Linux.
execute_process(COMMAND ${ADB} devices
OUTPUT_VARIABLE ADB_DEVICE_STRING
RESULT_VARIABLE ADB_DEVICE_STRING_RESULT)
string(REGEX REPLACE "[\t\n]" ";" ADB_DEVICE_LIST ${ADB_DEVICE_STRING})
list(FILTER ADB_DEVICE_LIST EXCLUDE REGEX ".*device.*")
list(REMOVE_ITEM ADB_DEVICE_LIST "")
list(LENGTH ADB_DEVICE_LIST ADB_DEVICE_LIST_LEN)
message(STATUS "ADB_DEVICE_LIST_LEN = ${ADB_DEVICE_LIST_LEN}")
foreach(SERIAL ${ADB_DEVICE_LIST})
message(STATUS "ADB_DEVICE_SERIAL = ${SERIAL}")
execute_process(COMMAND ${ADB} -s ${SERIAL} shell getprop ro.product.cpu.abi
OUTPUT_VARIABLE ADB_DEVICE_ABI
RESULT_VARIABLE ADB_DEVICE_ABI_RESULT)
string(STRIP ${ADB_DEVICE_ABI} ADB_DEVICE_ABI)
message(STATUS "ADB_DEVICE_ABI = ${ADB_DEVICE_ABI}")
if(${ANDROID_ABI} STREQUAL ${ADB_DEVICE_ABI})
# Prepare gtest for unit-test
add_custom_command(TARGET ${TEST_EUPHONY} POST_BUILD
COMMAND ${ADB} -s ${SERIAL} shell mkdir -p ${TARGET_TEST_LIB_DIR}
# Push necessary libraries
COMMAND ${ADB} -s ${SERIAL} push $<TARGET_FILE:euphony> ${TARGET_TEST_LIB_DIR}/
COMMAND ${ADB} -s ${SERIAL} push ${OBOE_LIBRARY_PATH} ${TARGET_TEST_LIB_DIR}/
COMMAND ${ADB} -s ${SERIAL} push ${LIBCPP_SHARED_PATH} ${TARGET_TEST_LIB_DIR}/
# Push Euphony Test Binary
COMMAND ${ADB} -s ${SERIAL} push $<TARGET_FILE:${TEST_EUPHONY}> ${TARGET_TEST_LIB_DIR}/
COMMAND ${ADB} -s ${SERIAL} shell chmod 755 ${TARGET_TEST_LIB_DIR}/${TEST_EUPHONY}
)
# Run gtest & get the result.
add_custom_command(TARGET ${TEST_EUPHONY} POST_BUILD
COMMAND ${CMAKE_COMMAND} -DADB:STRING="${ADB}" -DSERIAL:STRING="${SERIAL}" -DTARGET_TEST_LIB_DIR:STRING="${TARGET_TEST_LIB_DIR}" -P ${CMAKE_CURRENT_SOURCE_DIR}/cmake.run.test.script
)
endif()
endforeach() |
Beta Was this translation helpful? Give feedback.
-
|
넵 확인했습니다. 빌드 문제 살펴보겠습니다..! |
Beta Was this translation helpful? Give feedback.
-
|
EncodingTest 이름을 UTF16EncodingTest 등으로 바꿔도 문제가 발생하나요?! |
Beta Was this translation helpful? Give feedback.
-
|
너무나 혼란스럽네욬ㅋㅋ 도대체뭐지..!!?!??! |
Beta Was this translation helpful? Give feedback.
-
|
제것도 브랜치 만들었습니다 링크 드릴게요 ㅠㅠ |
Beta Was this translation helpful? Give feedback.
-
빌드가 됐었던건데 지금은 다시 안되는거니까 더 신기하네요! |
Beta Was this translation helpful? Give feedback.
-
|
@kuro11pow2 ㅠㅠ 전 준규님거 돌려도 역시 잘되네요 ㅠ |
Beta Was this translation helpful? Give feedback.
-
|
@yeonns |
Beta Was this translation helpful? Give feedback.
-
|
혹시 몰라서 제가 PR 하기 이전, 지웅멘토님이 마지막으로 커밋하신 상태로 가서 utf16 테스트 코드를 붙여서 돌려봤는데도 여전히 같은 에러가 발생해요!
|
Beta Was this translation helpful? Give feedback.
-
API 24 성공하는거 보구 혹시나해서 원래 디바이스 쓰던거 다시 연결해서 돌려봤는데 여전히 실패하네요 ㅠㅠ |
Beta Was this translation helpful? Give feedback.
-
|
하나만 하면 성공하고 TEST_P(UTF16CharsetTestFixture, UTF16DecodingTest2)
{
openCharset();
std::string source;
std::string expectedResult;
std::tie(source, expectedResult) = GetParam();
EXPECT_EQ("abcd", "abcd");
//HexVector actualResult = charset->encode(source);
// EXPECT_EQ("ac00", expectedResult);
}똑같은 테스트 케이스를 2번 하면 실패네요. TEST_P(UTF16CharsetTestFixture, UTF16DecodingTest2)
{
openCharset();
std::string source;
std::string expectedResult;
std::tie(source, expectedResult) = GetParam();
EXPECT_EQ("abcd", "abcd");
//HexVector actualResult = charset->encode(source);
// EXPECT_EQ("ac00", expectedResult);
}
TEST_P(UTF16CharsetTestFixture, UTF16DecodingTest)
{
openCharset();
std::string source;
std::string expectedResult;
std::tie(source, expectedResult) = GetParam();
EXPECT_EQ("abcd", "abcd");
//HexVector actualResult = charset->encode(source);
// EXPECT_EQ("ac00", expectedResult);
} |
Beta Was this translation helpful? Give feedback.
-
|
@designe |
Beta Was this translation helpful? Give feedback.
-
|
@designe 음 저는 2개든 1개든 문제가없네요; |
Beta Was this translation helpful? Give feedback.
-
|
하나만 있어도 gtest 에러인건가 |
Beta Was this translation helpful? Give feedback.
-
정말 신기한 문제네요!! |
Beta Was this translation helpful? Give feedback.
-
|
API 28 + 테스트케이스 227개 닌자? adb? 이슈 |
Beta Was this translation helpful? Give feedback.
-
|
우선은 알려진 이슈로 등록을 해둬야겠네요 ㅠ ㅋ |
Beta Was this translation helpful? Give feedback.
-
|
@designe @yeonns |
Beta Was this translation helpful? Give feedback.
-
|
@kuro11pow2 ㅋㅋㅋ 정말 오랜 토론이었네요!! 현업에서는 이런 일이 비일비재합니다 ㅋㅋㅋㅋㅋ |
Beta Was this translation helpful? Give feedback.
-
|
일단 제가 테스트 한 바로는 이렇게 됩니다! @designe 멘토님 혹시 Pixel, API 28 실패하셨나요? arm64-v8a + API 30 성공 성공 = utf16 테스트케이스를 정확히 주면 빌드 성공/ 이상하게 주면 gtest 에러 발생 |
Beta Was this translation helpful? Give feedback.
-
|
저는 28은 계속 문제가 발생하네요. |
Beta Was this translation helpful? Give feedback.
-
|
그 상태에서 227개 미만으로 유닛테스트 수를 줄이면 정상동작되실꺼에요 ㅋㅋㅋㅋ |
Beta Was this translation helpful? Give feedback.
-
아 잠시만요 저 안드7.0인줄 알았던 샤오미폰이 다시보니 9.0이네요? |
Beta Was this translation helpful? Give feedback.
-
|
오 ㅋㅋㅋㅋㅋ 그럼 28에 머가 있나보네요! |
Beta Was this translation helpful? Give feedback.
-
그리고 유닛테스트 수 딱 227개까지 돌아갑니다!! |
Beta Was this translation helpful? Give feedback.
-
|
아래와 같이 adb shell 접속한 상태에서 유닛테스트를 실행하면 에러없이 깔끔하게 떨어지는데 adb shell
cd /data/local/tmp/testEuphony/x86/
LD_LIBRARY_PATH=./ ./testEuphony아래는 에러가 발생하는군요. Segmentation Fault adb shell LD_LIBRARY_PATH=/data/local/tmp/testEuphony/x86/ /data/local/tmp/testEuphony/x86/testEuphony |
Beta Was this translation helpful? Give feedback.
-
|
adb 버전 문제일수도 있겠다는 생각이 드네요. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
네? |
Beta Was this translation helpful? Give feedback.
-
|
헠ㅋㅋㅋㅋ 혜성님 이메일 알아내서 co-author에 넣어드리려고 아이디 타고 github 프로필 들어간건데 확인을 엄청 빨리 하셨네요 ㅋㅋ |
Beta Was this translation helpful? Give feedback.
-
|
API28을 통해 빌드하는 경우, warning으로 알려주면 해당 이슈에 대한 좋은 솔루션이 될 수 있을 것 같네요! |
Beta Was this translation helpful? Give feedback.
-
넵 이 부분도 한번 알아볼게요!! |
Beta Was this translation helpful? Give feedback.
-
|
@designe
|
Beta Was this translation helpful? Give feedback.
정말 신기한 문제네요!!