Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSON:API Atomic Operations] Support lid #948

Open
SafaAlfulaij opened this issue Apr 12, 2022 · 0 comments
Open

[JSON:API Atomic Operations] Support lid #948

SafaAlfulaij opened this issue Apr 12, 2022 · 0 comments

Comments

@SafaAlfulaij
Copy link

SafaAlfulaij commented Apr 12, 2022

When dealing with atomic operations, updating local records (added in the operation) requires the lid for the backend to understand what to update.

if (resourceId !== undefined) {
resource.id = resourceId;
}

The fix is as simple as this:

 if (resourceId !== undefined) {
   resource.id = resourceId;
 } else {
   resource.lid = id
}

But needs a bit of testing and checking if JSON:API allows having lid for all requests (atomic and non-atomic) or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant