Skip to content
This repository was archived by the owner on Sep 30, 2023. It is now read-only.

preparations for js-ipfs 0.34 #223

Closed
alanshaw opened this issue Jan 15, 2019 · 7 comments
Closed

preparations for js-ipfs 0.34 #223

alanshaw opened this issue Jan 15, 2019 · 7 comments

Comments

@alanshaw
Copy link

👋 I upgraded ipfs to 0.34.0-rc.1 and ipfs-repo to ^0.26.0 and ran the tests and they all passed \o/

ipfs/js-ipfs#1721

@aphelionz
Copy link
Contributor

aphelionz commented Jan 15, 2019

🎉 That's great news. We'll stay tuned for the official 0.34.0 release.

@aphelionz
Copy link
Contributor

@alanshaw One thing I noticed in the browser tests:

You can get this result in the new feat/js-ipfs-0.34 branch I pushed to this repo by running npm run test:browser

 1) Entry - Persistency (js-ipfs)
      "before all" hook:
    Error: global leaks detected: sprintf, vsprintf

Perhaps it's just something we need to allow in the tests, or annotate the code to skip global leak detection?

Nice seeing you on the community call today, btw.

@aphelionz
Copy link
Contributor

Fixed those by adding mocha.setup({ globals }) config

@alanshaw
Copy link
Author

@aphelionz do you know where that's coming from? js-ipfs shouldn't be leaking anything to global scope. Would you mind opening an issue so we can get it fixed?

@aphelionz
Copy link
Contributor

@alanshaw No prob! Done: ipfs/js-ipfs#1836

@aphelionz aphelionz removed their assignment Feb 5, 2019
@aphelionz
Copy link
Contributor

Removing my assignment as I'm not currently working on this.

@aphelionz
Copy link
Contributor

Closing as we currently support 0.36

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants