This repository was archived by the owner on Sep 30, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 55
preparations for js-ipfs 0.34 #223
Labels
Comments
🎉 That's great news. We'll stay tuned for the official 0.34.0 release. |
@alanshaw One thing I noticed in the browser tests: You can get this result in the new
Perhaps it's just something we need to allow in the tests, or annotate the code to skip global leak detection? Nice seeing you on the community call today, btw. |
Closed
Fixed those by adding |
@aphelionz do you know where that's coming from? js-ipfs shouldn't be leaking anything to global scope. Would you mind opening an issue so we can get it fixed? |
@alanshaw No prob! Done: ipfs/js-ipfs#1836 |
Removing my assignment as I'm not currently working on this. |
Closing as we currently support 0.36 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
👋 I upgraded
ipfs
to0.34.0-rc.1
andipfs-repo
to^0.26.0
and ran the tests and they all passed \o/ipfs/js-ipfs#1721
The text was updated successfully, but these errors were encountered: