-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we really need to compile the tests? #2
Comments
I noticed that too. CMake seems to run diff-match-patch's CMake build too. There's probably a way to avoid it completely since only the header file is needed for this module.
|
Hi,
I went back to the sources of diff-match-patch and found out that they have
a Lua version. Currently fiddling around a bit with it to see if a pure Lua
version is feasible (which I think it is) This would greatly alliviate the
situation and Win1x and macOS. My current Win1x (yes, I know... I would
rather not have to be on it) started complaining about the distributed
diff.dll
…On Thu, 29 Dec 2022 at 16:00, orbitalquark ***@***.***> wrote:
I noticed that too. CMake seems to run diff-match-patch's CMake build too.
There's probably a way to avoid it completely since only the header file is
needed for this module.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZKU4EO63MPKIY2DZETC33WPWRQLANCNFSM6AAAAAATL35INU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler
Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run
a leader-deposed hook here, but we can't yet
|
Originally I used the pure Lua version, but it was **really** slow, so I had to fall back on the C++ version. Obviously that hurts from a portability perspective :(
|
I'm dumb. I initially realized this, but I forgot that I updated the GitHub Actions build script to only build for the "diff" target: `cmake --build build --config Release --target diff -j`. That will only build the module. From the build directory you should also just be able to run `make diff` if you're using CMake's Makefile generator.
|
OK, anyhow I made it... just to make sure that I can use it without having the OS complaining. Happy New Year |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Would it be possible to avoid compiling/running the tests? They are really expensive time-wise.
The text was updated successfully, but these errors were encountered: