feat(client): allow configuring env via system properties

Author: stainless-app[bot]

README.md

@@ -46,7 +46,8 @@ import com.withorb.api.client.okhttp.OrbOkHttpClient;
 import com.withorb.api.models.Customer;
 import com.withorb.api.models.CustomerCreateParams;
 
-// Configures using the `ORB_API_KEY`, `ORB_WEBHOOK_SECRET` and `ORB_BASE_URL` environment variables
+// Configures using the `orb.apiKey`, `orb.webhookSecret` and `orb.baseUrl` system properties
+// Or configures using the `ORB_API_KEY`, `ORB_WEBHOOK_SECRET` and `ORB_BASE_URL` environment variables
 OrbClient client = OrbOkHttpClient.fromEnv();
 
 CustomerCreateParams params = CustomerCreateParams.builder()
@@ -58,13 +59,14 @@ Customer customer = client.customers().create(params);
 
 ## Client configuration
 
-Configure the client using environment variables:
+Configure the client using system properties or environment variables:
 
 ```java
 import com.withorb.api.client.OrbClient;
 import com.withorb.api.client.okhttp.OrbOkHttpClient;
 
-// Configures using the `ORB_API_KEY`, `ORB_WEBHOOK_SECRET` and `ORB_BASE_URL` environment variables
+// Configures using the `orb.apiKey`, `orb.webhookSecret` and `orb.baseUrl` system properties
+// Or configures using the `ORB_API_KEY`, `ORB_WEBHOOK_SECRET` and `ORB_BASE_URL` environment variables
 OrbClient client = OrbOkHttpClient.fromEnv();
 ```
 
@@ -86,19 +88,22 @@ import com.withorb.api.client.OrbClient;
 import com.withorb.api.client.okhttp.OrbOkHttpClient;
 
 OrbClient client = OrbOkHttpClient.builder()
-    // Configures using the `ORB_API_KEY`, `ORB_WEBHOOK_SECRET` and `ORB_BASE_URL` environment variables
+    // Configures using the `orb.apiKey`, `orb.webhookSecret` and `orb.baseUrl` system properties
+    Or configures using the `ORB_API_KEY`, `ORB_WEBHOOK_SECRET` and `ORB_BASE_URL` environment variables
     .fromEnv()
     .apiKey("My API Key")
     .build();
 ```
 
 See this table for the available options:
 
-| Setter          | Environment variable | Required | Default value                  |
-| --------------- | -------------------- | -------- | ------------------------------ |
-| `apiKey`        | `ORB_API_KEY`        | true     | -                              |
-| `webhookSecret` | `ORB_WEBHOOK_SECRET` | false    | -                              |
-| `baseUrl`       | `ORB_BASE_URL`       | true     | `"https://api.withorb.com/v1"` |
+| Setter          | System property     | Environment variable | Required | Default value                  |
+| --------------- | ------------------- | -------------------- | -------- | ------------------------------ |
+| `apiKey`        | `orb.apiKey`        | `ORB_API_KEY`        | true     | -                              |
+| `webhookSecret` | `orb.webhookSecret` | `ORB_WEBHOOK_SECRET` | false    | -                              |
+| `baseUrl`       | `orb.baseUrl`       | `ORB_BASE_URL`       | true     | `"https://api.withorb.com/v1"` |
+
+System properties take precedence over environment variables.
 
 > [!TIP]
 > Don't create more than one client in the same application. Each client has a connection pool and
@@ -144,7 +149,8 @@ import com.withorb.api.models.Customer;
 import com.withorb.api.models.CustomerCreateParams;
 import java.util.concurrent.CompletableFuture;
 
-// Configures using the `ORB_API_KEY`, `ORB_WEBHOOK_SECRET` and `ORB_BASE_URL` environment variables
+// Configures using the `orb.apiKey`, `orb.webhookSecret` and `orb.baseUrl` system properties
+// Or configures using the `ORB_API_KEY`, `ORB_WEBHOOK_SECRET` and `ORB_BASE_URL` environment variables
 OrbClient client = OrbOkHttpClient.fromEnv();
 
 CustomerCreateParams params = CustomerCreateParams.builder()
@@ -163,7 +169,8 @@ import com.withorb.api.models.Customer;
 import com.withorb.api.models.CustomerCreateParams;
 import java.util.concurrent.CompletableFuture;
 
-// Configures using the `ORB_API_KEY`, `ORB_WEBHOOK_SECRET` and `ORB_BASE_URL` environment variables
+// Configures using the `orb.apiKey`, `orb.webhookSecret` and `orb.baseUrl` system properties
+// Or configures using the `ORB_API_KEY`, `ORB_WEBHOOK_SECRET` and `ORB_BASE_URL` environment variables
 OrbClientAsync client = OrbOkHttpClientAsync.fromEnv();
 
 CustomerCreateParams params = CustomerCreateParams.builder()

orb-java-core/src/main/kotlin/com/withorb/api/core/ClientOptions.kt

@@ -242,9 +242,13 @@ private constructor(
         fun timeout(): Timeout = timeout
 
         fun fromEnv() = apply {
-            System.getenv("ORB_BASE_URL")?.let { baseUrl(it) }
-            System.getenv("ORB_API_KEY")?.let { apiKey(it) }
-            System.getenv("ORB_WEBHOOK_SECRET")?.let { webhookSecret(it) }
+            (System.getProperty("orb.baseUrl") ?: System.getenv("ORB_BASE_URL"))?.let {
+                baseUrl(it)
+            }
+            (System.getProperty("orb.apiKey") ?: System.getenv("ORB_API_KEY"))?.let { apiKey(it) }
+            (System.getProperty("orb.webhookSecret") ?: System.getenv("ORB_WEBHOOK_SECRET"))?.let {
+                webhookSecret(it)
+            }
         }
 
         /**