Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question re: rotation adjustments harming trajectory features... #7

Open
SteveDE opened this issue Mar 30, 2022 · 2 comments
Open

Question re: rotation adjustments harming trajectory features... #7

SteveDE opened this issue Mar 30, 2022 · 2 comments

Comments

@SteveDE
Copy link

SteveDE commented Mar 30, 2022

Thanks again Daniel for sharing this excellent demo - one thing that jumped out while tuning sim/adjustment is how distorted trajectory futures become. I expect this is not avoidable if you want correction but wondered if you had any thoughts/guidance on it?

With rotation correction turning the root faster or slower than the animation your future position features become deflected (of course they are, because they are stored relative to the queried animation frame) - for our content this means my 180 idle-to-jog get tossed out in favor of visually worse 'turning jogs' because of this deflection. Intuitively it doesn't seem like a benefit to matching quality, the future positions are not actually deflected in the animation (the turn 180 stays along the axis).

I can iterate with animators to more closely match the sim of course to reduce the harm but I wondered if you've already put thought into this?

@orangeduck
Copy link
Owner

orangeduck commented Mar 30, 2022

Hi Steve,

Yes it's a really good point, and something I think could probably do with addressing.

Perhaps one way to think about it is this - right now we adjust the immediate root rotation so that the simulation and animation match, but instead we would be better off adjusting the rotation so that the future simulated trajectory, and future animation trajectory match. If we did this we would only adjust the root if it means getting a match closer to what we asked for - and never adjust the root in a way that should deflect away from out request. Does that make sense?

Dan

@SteveDE
Copy link
Author

SteveDE commented Mar 30, 2022

Thank you Dan, it might take me a while to understand your suggestion - one thing I have tried quick was to capture the world space rotation at the point of transition/pose transition and use that as a constant w/the actual query feature frame rotation for query_compute_trajectory* transform of sim trajectories (instead of the continuously updated/corrected root rotation). This works... until it explodes during other transitions. I'm a bit out of my depths here but I will continue to hammer on it in case it bears fruit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants