Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timeout.rb from upstream #3426

Open
eregon opened this issue Feb 1, 2024 · 2 comments
Open

Use timeout.rb from upstream #3426

eregon opened this issue Feb 1, 2024 · 2 comments

Comments

@eregon
Copy link
Member

eregon commented Feb 1, 2024

Currently we have a custom version in https://github.com/oracle/truffleruby/blob/90bfaa00401778f11849dbca05eb1bd008271c1b/lib/truffle/timeout.rb.
But now that upstream (the gem, and also the version shipped in 3.2) also avoids creating a thread per Timeout.timeout call, there is no much reason to use our custom timeout.rb, and in fact it would be more compatible to use upstream.

@olleolleolle
Copy link
Contributor

olleolleolle commented Aug 28, 2024

👋 Hi! I recently looked at the CI run on the upstream repo. The job truffleruby-head on ubuntu-latest took a while (>26 minutes) to do anything in the step that executes the tests. https://github.com/ruby/timeout/actions/runs/10595331126/job/29360878189

The step is...
bundle exec rake test

Got ideas on what's going on? The macos-latest seem to be done in 5s.

(If you wish to shunt this Issue comment to its own something, Discussion, Issue, comment thread in the ruby/timeout repo, please shunt away.)

@eregon
Copy link
Member Author

eregon commented Aug 28, 2024

@olleolleolle I moved your comment to a new issue: #3652 since it's unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants