-
Notifications
You must be signed in to change notification settings - Fork 779
content API endpoint #3048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The above assumes text files that contain newlines. Perhaps the controller could verify the type of the file ( |
After implementing the above (without pagination) I have to say it is not clear to me how beneficial is to have this endpoint. Anyone (authorized, if authorization config is in place) can download the content of any file, split it into lines and assign them line numbers. It sort of makes sense when combined with the text file detection (as suggested in the above comment) and maybe if pagination (for long files) is supported. @jbaek7023 ? I was also thinking about exposing |
I'm trying to implement this Front-End talking to OpenGrok API (Inspired by SourceGraph). Annotation and History can be shown by the toggling "Annotate" or "clicking CL" button. I think your implementation will be super useful in the future for anyone who wants to OpenGrok indexing engine + I don't think we'll need a pagination here. Thanks again for the quick turnaround...!! Your impact is big. |
|
@idodeclare No, all the DOM tags are all valuable. I just want to override the style.css files. Which makes the analysis from source text will be necessary - I still want to keep the DOM tags () in the JSON data. (Apologies in advance if this is a dumb thought) |
@jbaek7023 no I was referring to @vladak mentioning calling |
- no line number support fixes oracle#3048
thanks @idodeclare , that's what I needed. |
Is your feature request related to a problem? Please describe.
#3042 listed a few new API endpoints that would be useful to have. This tracks the addition of the /content endpoint for getting content of a file.
Describe the solution you'd like
Return JSON array of objects:
The endpoint should support a parameter to specify revision of the file. It may support paging.
The text was updated successfully, but these errors were encountered: