Skip to content

Commit ed14819

Browse files
committed
6.7 release
1 parent 8a5855b commit ed14819

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

Diff for: doc/src/release_notes.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ node-oracledb Release Notes
88
For deprecated and desupported features, see
99
:ref:`Deprecations and desupported features <deprecations>`.
1010

11-
node-oracledb `v6.7.0 <https://github.com/oracle/node-oracledb/compare/v6.6.0...v6.7.0>`__ (TBD)
11+
node-oracledb `v6.7.0 <https://github.com/oracle/node-oracledb/compare/v6.6.0...v6.7.0>`__ (18 Nov 2024)
1212
---------------------------------------------------------------------------------------------------------
1313

1414
Common Changes

Diff for: test/connection.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -826,27 +826,27 @@ describe('1. connection.js', function() {
826826

827827
const conn = await oracledb.getConnection(dbaConfig);
828828

829+
// Whitespaces, comma, ( and ) are replaced by ? for the program name
830+
// in V$SESSION
831+
const sanitizedProgName = process.argv0.replace(/[\s(),]/g, '?');
832+
829833
// Fetch values from v$session
830834
let res = await conn.execute(sqlSessionDetails);
831835
assert.strictEqual(res.rows[0][0], os.hostname());
832836
assert.strictEqual(res.rows[0][1], os.userInfo().username);
833837
assert.strictEqual(res.rows[0][2], 'unknown');
834-
// Whitespaces, ( and ) are replaced by ? for the program name
835-
// in V$SESSION
836-
assert.strictEqual(res.rows[0][3], process.argv0.replace(/[\s()]/g, '?'));
838+
assert.strictEqual(res.rows[0][3], sanitizedProgName);
837839

838840
if (dbConfig.test.drcp) {
839841
const bindParams = {
840842
machine: os.hostname(),
841843
terminal: 'unknown',
842-
program: process.argv0
844+
program: sanitizedProgName
843845
};
844846
res = await conn.execute(sqlDRCPSessionDetails, bindParams);
845847
assert.deepStrictEqual(res.rows[0][0], os.hostname());
846848
assert.deepStrictEqual(res.rows[0][1], 'unknown');
847-
// Whitespaces, ( and ) are replaced by ? for the program name
848-
// in V$SESSION
849-
assert.deepStrictEqual(res.rows[0][2], process.argv0.replace(/[\s()]/g, '?'));
849+
assert.deepStrictEqual(res.rows[0][2], sanitizedProgName);
850850
}
851851

852852
res = await conn.execute(sqlDriverName);

0 commit comments

Comments
 (0)