chore: fix pylint message redefined-variable-type

jenstroeger · jenstroeger · commit efaebee2c5b8 · 2024-10-01T19:17:15.000+10:00
diff --git a/src/macaron/slsa_analyzer/checks/build_as_code_check.py b/src/macaron/slsa_analyzer/checks/build_as_code_check.py
@@ -202,7 +202,7 @@ def run_check(self, ctx: AnalyzeContext) -> CheckResultData:
                                         confidence=Confidence.HIGH,
                                     )
                                 )
-                                overall_res = CheckResultType.PASSED
+                                overall_res = CheckResultType.PASSED  # pylint: disable=redefined-variable-type
                 try:
                     for build_command in ci_service.get_build_tool_commands(
                         callgraph=ci_info["callgraph"], build_tool=tool
@@ -263,7 +263,7 @@ def run_check(self, ctx: AnalyzeContext) -> CheckResultData:
                                     confidence=confidence,
                                 )
                             )
-                            overall_res = CheckResultType.PASSED
+                            overall_res = CheckResultType.PASSED   # pylint: disable=redefined-variable-type
                 except CallGraphError as error:
                     logger.debug(error)
 
@@ -292,7 +292,7 @@ def run_check(self, ctx: AnalyzeContext) -> CheckResultData:
                                     confidence=Confidence.LOW,
                                 )
                             )
-                            overall_res = CheckResultType.PASSED
+                            overall_res = CheckResultType.PASSED   # pylint: disable=redefined-variable-type
 
         # The check passing is contingent on at least one passing, if
         # one passes treat whole check as passing. We do still need to
diff --git a/src/macaron/slsa_analyzer/checks/build_service_check.py b/src/macaron/slsa_analyzer/checks/build_service_check.py
@@ -164,7 +164,7 @@ def run_check(self, ctx: AnalyzeContext) -> CheckResultData:
                                     confidence=confidence,
                                 )
                             )
-                            overall_res = CheckResultType.PASSED
+                            overall_res = CheckResultType.PASSED  # pylint: disable=redefined-variable-type
                 except CallGraphError as error:
                     logger.debug(error)
 
@@ -193,7 +193,7 @@ def run_check(self, ctx: AnalyzeContext) -> CheckResultData:
                                     confidence=Confidence.LOW,
                                 )
                             )
-                            overall_res = CheckResultType.PASSED
+                            overall_res = CheckResultType.PASSED  # pylint: disable=redefined-variable-type
 
         # The check passing is contingent on at least one passing, if
         # one passes treat whole check as passing. We do still need to
diff --git a/src/macaron/slsa_analyzer/checks/provenance_l3_check.py b/src/macaron/slsa_analyzer/checks/provenance_l3_check.py
@@ -451,8 +451,7 @@ class Feedback(NamedTuple):
                 result_value = CheckResultType.FAILED
             else:
                 result_tables.append(ProvenanceL3VerifiedFacts(confidence=Confidence.HIGH))
-                result_value = CheckResultType.PASSED
-                return CheckResultData(result_tables=result_tables, result_type=result_value)
+                return CheckResultData(result_tables=result_tables, result_type=CheckResultType.PASSED)
 
         return CheckResultData(result_tables=result_tables, result_type=result_value)
 

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,7 @@ def run_check(self, ctx: AnalyzeContext) -> CheckResultData:`
`202`	`202`	`confidence=Confidence.HIGH,`
`203`	`203`	`)`
`204`	`204`	`)`
`205`		`- overall_res = CheckResultType.PASSED`
	`205`	`+ overall_res = CheckResultType.PASSED # pylint: disable=redefined-variable-type`
`206`	`206`	`try:`
`207`	`207`	`for build_command in ci_service.get_build_tool_commands(`
`208`	`208`	`callgraph=ci_info["callgraph"], build_tool=tool`
`@@ -263,7 +263,7 @@ def run_check(self, ctx: AnalyzeContext) -> CheckResultData:`
`263`	`263`	`confidence=confidence,`
`264`	`264`	`)`
`265`	`265`	`)`
`266`		`- overall_res = CheckResultType.PASSED`
	`266`	`+ overall_res = CheckResultType.PASSED # pylint: disable=redefined-variable-type`
`267`	`267`	`except CallGraphError as error:`
`268`	`268`	`logger.debug(error)`
`269`	`269`
`@@ -292,7 +292,7 @@ def run_check(self, ctx: AnalyzeContext) -> CheckResultData:`
`292`	`292`	`confidence=Confidence.LOW,`
`293`	`293`	`)`
`294`	`294`	`)`
`295`		`- overall_res = CheckResultType.PASSED`
	`295`	`+ overall_res = CheckResultType.PASSED # pylint: disable=redefined-variable-type`
`296`	`296`
`297`	`297`	`# The check passing is contingent on at least one passing, if`
`298`	`298`	`# one passes treat whole check as passing. We do still need to`
Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ def run_check(self, ctx: AnalyzeContext) -> CheckResultData:`
`164`	`164`	`confidence=confidence,`
`165`	`165`	`)`
`166`	`166`	`)`
`167`		`- overall_res = CheckResultType.PASSED`
	`167`	`+ overall_res = CheckResultType.PASSED # pylint: disable=redefined-variable-type`
`168`	`168`	`except CallGraphError as error:`
`169`	`169`	`logger.debug(error)`
`170`	`170`
`@@ -193,7 +193,7 @@ def run_check(self, ctx: AnalyzeContext) -> CheckResultData:`
`193`	`193`	`confidence=Confidence.LOW,`
`194`	`194`	`)`
`195`	`195`	`)`
`196`		`- overall_res = CheckResultType.PASSED`
	`196`	`+ overall_res = CheckResultType.PASSED # pylint: disable=redefined-variable-type`
`197`	`197`
`198`	`198`	`# The check passing is contingent on at least one passing, if`
`199`	`199`	`# one passes treat whole check as passing. We do still need to`