update: add backward compatibility support for Android sync and async decisions in OptimizelyUserContext

Author: FarhanAnjum-opti

core-api/src/main/java/com/optimizely/ab/OptimizelyUserContext.java

@@ -208,6 +208,7 @@ public Map<String, OptimizelyDecision> decideAll() {
     /**
      * Returns a decision result ({@link OptimizelyDecision}) for a given flag key and a user context, 
      * which contains all data required to deliver the flag. This method skips CMAB logic.
+     * backward compatibility support for android sync decisions
      * @param key A flag key for which a decision will be made.
      * @param options A list of options for decision-making.
      * @return A decision result.
@@ -217,20 +218,10 @@ public OptimizelyDecision decideSync(@Nonnull String key,
         return optimizely.decideSync(copy(), key, options);
     }
 
-    /**
-     * Returns a decision result ({@link OptimizelyDecision}) for a given flag key and a user context,
-     * which contains all data required to deliver the flag. This method skips CMAB logic.
-     *
-     * @param key A flag key for which a decision will be made.
-     * @return A decision result.
-     */
-    public OptimizelyDecision decideSync(@Nonnull String key) {
-        return decideSync(key, Collections.emptyList());
-    }
-
     /**
      * Returns a key-map of decision results ({@link OptimizelyDecision}) for multiple flag keys and a user context.
      * This method skips CMAB logic.
+     * backward compatibility support for android sync decisions
      * @param keys A list of flag keys for which decisions will be made.
      * @param options A list of options for decision-making.
      * @return All decision results mapped by flag keys.
@@ -240,41 +231,20 @@ public Map<String, OptimizelyDecision> decideForKeysSync(@Nonnull List<String> k
         return optimizely.decideForKeysSync(copy(), keys, options);
     }
 
-    /**
-     * Returns a key-map of decision results for multiple flag keys and a user context.
-     * This method skips CMAB logic.
-     *
-     * @param keys A list of flag keys for which decisions will be made.
-     * @return All decision results mapped by flag keys.
-     */
-    public Map<String, OptimizelyDecision> decideForKeysSync(@Nonnull List<String> keys) {
-        return decideForKeysSync(keys, Collections.emptyList());
-    }
-
     /**
      * Returns a key-map of decision results ({@link OptimizelyDecision}) for all active flag keys.
      * This method skips CMAB logic.
-     *
+     * backward compatibility support for android sync decisions
      * @param options A list of options for decision-making.
      * @return All decision results mapped by flag keys.
      */
     public Map<String, OptimizelyDecision> decideAllSync(@Nonnull List<OptimizelyDecideOption> options) {
         return optimizely.decideAllSync(copy(), options);
     }
 
-    /**
-     * Returns a key-map of decision results ({@link OptimizelyDecision}) for all active flag keys.
-     * This method skips CMAB logic.
-     *
-     * @return A dictionary of all decision results, mapped by flag keys.
-     */
-    public Map<String, OptimizelyDecision> decideAllSync() {
-        return decideAllSync(Collections.emptyList());
-    }
-
     /**
      * Returns a decision result asynchronously for a given flag key and a user context.
-     *
+     * support for android async decisions
      * @param key A flag key for which a decision will be made.
      * @param callback A callback to invoke when the decision is available.
      * @param options A list of options for decision-making.
@@ -286,19 +256,10 @@ public void decideAsync(@Nonnull String key,
         fetcher.start();
     }
 
-    /**
-     * Returns a decision result asynchronously for a given flag key and a user context.
-     *
-     * @param key A flag key for which a decision will be made.
-     * @param callback A callback to invoke when the decision is available.
-     */
-    public void decideAsync(@Nonnull String key, @Nonnull OptimizelyDecisionCallback callback) {
-        decideAsync(key, callback, Collections.emptyList());
-    }
 
     /**
      * Returns decision results asynchronously for multiple flag keys.
-     *
+     * support for android async decisions
      * @param keys A list of flag keys for which decisions will be made.
      * @param callback A callback to invoke when decisions are available.
      * @param options A list of options for decision-making.
@@ -310,19 +271,9 @@ public void decideForKeysAsync(@Nonnull List<String> keys,
         fetcher.start();
     }
 
-    /**
-     * Returns decision results asynchronously for multiple flag keys.
-     * 
-     * @param keys A list of flag keys for which decisions will be made.
-     * @param callback A callback to invoke when decisions are available.
-     */
-    public void decideForKeysAsync(@Nonnull List<String> keys, @Nonnull OptimizelyDecisionsCallback callback) {
-        decideForKeysAsync(keys, callback, Collections.emptyList());
-    }
-
     /**
      * Returns decision results asynchronously for all active flag keys.
-     *
+     * support for android async decisions
      * @param callback A callback to invoke when decisions are available.
      * @param options A list of options for decision-making.
      */
@@ -332,15 +283,6 @@ public void decideAllAsync(@Nonnull OptimizelyDecisionsCallback callback,
         fetcher.start();
     }
 
-    /**
-     * Returns decision results asynchronously for all active flag keys.
-     * 
-     * @param callback A callback to invoke when decisions are available.
-     */
-    public void decideAllAsync(@Nonnull OptimizelyDecisionsCallback callback) {
-        decideAllAsync(callback, Collections.emptyList());
-    }
-
     /**
      * Track an event.
      *