Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result of request should be a log field, not stringified #103

Open
brensch opened this issue Mar 17, 2022 · 0 comments
Open

Result of request should be a log field, not stringified #103

brensch opened this issue Mar 17, 2022 · 0 comments

Comments

@brensch
Copy link

brensch commented Mar 17, 2022

cli.Config.Logger.Debugf("Request processed. The result: %+v", result)

The request response in this log is being stringified into the log message, making it more difficult to gain insights programmatically from the logs. The logger object is from Logrus, so we should use a .WithField() for the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant