Merge pull request #76 from opsgenie/int-action-imp-ignore

add ignore to integration actions
opsgenie · Dec 24, 2020 · 0158913 · 0158913
2 parents 4951c0d + dd5eb32
commit 0158913
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/integration/integration_test.go b/integration/integration_test.go
@@ -206,14 +206,14 @@ func TestResponders_Validate(t *testing.T) {
 		{Type: "Cem"},
 	}
 	err = validateResponders(responders)
-	assert.Equal(t, err.Error(), errors.New("Responder type should be one of these: " +
+	assert.Equal(t, err.Error(), errors.New("Responder type should be one of these: "+
 		"'User', 'Team', 'Schedule', 'Escalation'").Error())
 
 	responders = []Responder{
 		{Type: User},
 	}
 	err = validateResponders(responders)
-	assert.Equal(t, err.Error(), errors.New("For responder type user either" +
+	assert.Equal(t, err.Error(), errors.New("For responder type user either"+
 		" username or id must be provided.").Error())
 
 	responders = []Responder{
@@ -230,7 +230,7 @@ func TestResponders_Validate(t *testing.T) {
 			Type: Team},
 	}
 	err = validateResponders(responders)
-	assert.Equal(t, err.Error(), errors.New("For responder type team either team" +
+	assert.Equal(t, err.Error(), errors.New("For responder type team either team"+
 		" name or id must be provided.").Error())
 
 	responders = []Responder{
@@ -248,7 +248,7 @@ func TestResponders_Validate(t *testing.T) {
 		},
 	}
 	err = validateResponders(responders)
-	assert.Equal(t, err.Error(), errors.New("For responder type schedule either schedule" +
+	assert.Equal(t, err.Error(), errors.New("For responder type schedule either schedule"+
 		" name or id must be provided.").Error())
 
 	responders = []Responder{
@@ -266,7 +266,7 @@ func TestResponders_Validate(t *testing.T) {
 		},
 	}
 	err = validateResponders(responders)
-	assert.Equal(t, err.Error(), errors.New("For responder type escalation either escalation" +
+	assert.Equal(t, err.Error(), errors.New("For responder type escalation either escalation"+
 		" name or id must be provided.").Error())
 
 	responders = []Responder{
@@ -282,7 +282,7 @@ func TestResponders_Validate(t *testing.T) {
 func TestActionType_Validate(t *testing.T) {
 	err := validateActionType("cem")
 	assert.Equal(t, err.Error(), errors.New("Action type should be one of these: "+
-		"'Create','Close','Acknowledge','AddNote'").Error())
+		"'Create','Close','Acknowledge','AddNote','Ignore'").Error())
 
 	err = validateActionType(Create)
 	assert.Nil(t, err)
@@ -295,6 +295,9 @@ func TestActionType_Validate(t *testing.T) {
 
 	err = validateActionType(AddNote)
 	assert.Nil(t, err)
+
+	err = validateActionType(Ignore)
+	assert.Nil(t, err)
 }
 
 func TestConditionMatchType_Validate(t *testing.T) {

diff --git a/integration/request.go b/integration/request.go
@@ -370,6 +370,7 @@ type UpdateAllIntegrationActionsRequest struct {
 	Close       []IntegrationAction `json:"close"`
 	Acknowledge []IntegrationAction `json:"acknowledge"`
 	AddNote     []IntegrationAction `json:"addNote"`
+	Ignore      []IntegrationAction `json:"ignore"`
 }
 
 type IntegrationAction struct {
@@ -474,11 +475,11 @@ func validateResponders(responders []Responder) error {
 
 func validateActionType(actionType ActionType) error {
 	switch actionType {
-	case Create, Close, Acknowledge, AddNote:
+	case Create, Close, Acknowledge, AddNote, Ignore:
 		return nil
 	}
 	return errors.New("Action type should be one of these: " +
-		"'Create','Close','Acknowledge','AddNote'")
+		"'Create','Close','Acknowledge','AddNote','Ignore'")
 }
 
 func validateConditionMatchType(matchType og.ConditionMatchType) error {

diff --git a/integration/result.go b/integration/result.go
@@ -162,6 +162,7 @@ const (
 	Close       ActionType = "close"
 	Acknowledge ActionType = "acknowledge"
 	AddNote     ActionType = "AddNote"
+	Ignore      ActionType = "ignore"
 )
 
 type Responder struct {