Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex in type configuration prevents using Cloudformation dynamic references. #27

Open
kiwi-33 opened this issue Jun 21, 2023 · 1 comment

Comments

@kiwi-33
Copy link

kiwi-33 commented Jun 21, 2023

The string validation for the OpsgenieApiKey value in the configuration schema of the cloudformation extension is:

"OpsgenieApiKey": {
          "type": "string",
          "pattern": "[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12}"
        }

With this strict check, it is not possible to use cross-account dynamic references using template values. The advice for defining account level configuration advises to use dynamic references. Without this, any secret API key is compromised as users within an AWS account will be able to navigate to the cloudformation extension and view the secret value in plain text in the extension configuration.

Can the schema be updated to remove this validation? Or at least also support some pattern like\{\{.*\}\} that will allow template values in this format {{resolve:secretsmanager:arn:aws:secretsmanager:region:123456789012:secret:secretname:SecretString:key}} ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants