Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

Template errors should have higher level ? #170

Open
doloopwhile opened this issue Dec 7, 2021 · 0 comments
Open

Template errors should have higher level ? #170

doloopwhile opened this issue Dec 7, 2021 · 0 comments

Comments

@doloopwhile
Copy link

Error messages like the following are dumped for template errors.

{"level":"debug","error":"template: template:1:18: executing \"template\" at <.involvedObject.namespace>: can't evaluate field involvedObject in type *kube.EnhancedEvent","sink":"slack","event":"Readiness probe failed: cat: can't open '/tmp/healthy': No such file or directory\n","time":"2021-12-07T06:26:37Z","caller":"/app/pkg/exporter/channel_registry.go:59","message":"Cannot send event"}

I suggest that the level of this kind of error message should be "error".

This is because if we overlook a failure to notify, we can also overlook a serious error that should have been notified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant