Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

www/caddy: Shortcut buttons do not work anymore #4509

Closed
3 tasks done
Monviech opened this issue Jan 29, 2025 · 2 comments · Fixed by #4525
Closed
3 tasks done

www/caddy: Shortcut buttons do not work anymore #4509

Monviech opened this issue Jan 29, 2025 · 2 comments · Fixed by #4525
Assignees
@Monviech
Labels
bug Production bug

Comments

@Monviech
Copy link
Member

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

Seems like these buttons do not work anymore, find out why when there's time. Nothing wild as theyre optional.

plugins/www/caddy/src/opnsense/mvc/app/views/OPNsense/Caddy/reverse_proxy.volt

Line 229 in 49467c3

// Add click event listener for "Add Handler" button

@Monviech Monviech added the bug Production bug label Jan 29, 2025
@Monviech Monviech self-assigned this Jan 29, 2025
@Monviech
Copy link
Member Author

The issue is that the add button does not have an ID anymore:

plugins/www/caddy/src/opnsense/mvc/app/views/OPNsense/Caddy/reverse_proxy.volt

Line 374 in 7bbd455

<button id="addReverseProxyBtn" data-action="add" type="button" class="btn btn-xs btn-primary"><span class="fa fa-plus"></span></button>

plugins/www/caddy/src/opnsense/mvc/app/views/OPNsense/Caddy/reverse_proxy.volt

Line 243 in 7bbd455

$("#addReverseProxyBtn").click();

In the new template the buttons do not have an ID:

https://github.com/opnsense/core/blob/6f464fc06481bd56276502037a1dc284068cf74e/src/opnsense/mvc/app/views/layout_partials/base_bootgrid_table.volt#L20

@Monviech Monviech mentioned this issue Jan 30, 2025
Closed
@Monviech
Copy link
Member Author

Monviech commented Feb 3, 2025 •
edited
Loading

Removing these buttons will be the best choice.

EDIT: Just fix the bug and do not try to reinvent the wheel there. New PR fixes just the buttons.

@Monviech Monviech mentioned this issue Feb 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Monviech Monviech

Labels
bug Production bug
Milestone
No milestone
1 participant
@Monviech