refactor: rename isEmptyButZero to isEmptyString

Author: kumy

src/opnsense/mvc/app/models/OPNsense/Base/Constraints/ComparedToFieldConstraint.php

@@ -54,13 +54,13 @@ public function validate($validator, $attribute): bool
         $node = $this->getOption('node');
         $field_name = $this->getOption('field');
         $operator = $this->getOption('operator');
-        if ($node && !($node->isEmptyButZero() || empty($operator) || empty($field_name))) {
+        if ($node && !($node->isEmptyString() || empty($operator) || empty($field_name))) {
             $parent_node = $node->getParentNode();
             $other_node_content = $parent_node->$field_name;
 
             // if the other field is not set, or invalid type -> ignore this constraint
             if (
-                is_null($other_node_content) || $other_node_content->isEmptyButZero() ||
+                is_null($other_node_content) || $other_node_content->isEmptyString() ||
                 !$node->isNumeric() && !$other_node_content->isNumeric()
             ) {
                 return true;

src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php

@@ -513,7 +513,7 @@ public function isEmpty(): bool
      * check if current value is empty AND NOT zero (either boolean field as false or an empty field)
      * @return bool
      */
-    public function isEmptyButZero(): bool
+    public function isEmptyString(): bool
     {
         return $this->getCurrentValue() !== "0" && $this->isEmpty();
     }