fix: Introduce asFloat in BaseConstraint

Author: kumy

src/opnsense/mvc/app/models/OPNsense/Base/Constraints/BaseConstraint.php

@@ -54,11 +54,19 @@ public function isEmpty($node)
      * @param $node
      * @return bool
      */
-    public function isNumeric($node)
-    {
+    public function isNumeric($node): bool {
         return is_numeric((string)$node->getCurrentValue());
     }
 
+    /**
+     * Try to convert to current value as float
+     * @param $node
+     * @return float
+     */
+    public function asFloat($node): float {
+        return floatval((string)$node->getCurrentValue());
+    }
+
     /**
      * @param $validator
      * @param $attribute

src/opnsense/mvc/app/models/OPNsense/Base/Constraints/ComparedToFieldConstraint.php

@@ -69,8 +69,8 @@ public function validate($validator, $attribute): bool
             if (
                 !$this->is_constraint_fulfilled(
                     $operator,
-                    floatval((string)$node->getCurrentValue()),
-                    floatval((string)$other_node_content->getCurrentValue())
+                    $this->asFloat($node),
+                    $this->asFloat($other_node_content)
                 )
             ) {
                 $this->appendMessage($validator, $attribute);