-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[storage]: Front-end Enable / Disable Namespace Proto-Bufs #178
Comments
What's the use case? Specifically, the use case for having an RPC to enable/disable? Certainly namespaces will get enabled/disabled as part of other operations (during updates and such), but I don't see a flow where the client needs to do this. |
@jainvipin had those APIs maybe he can comment on the use case |
The goal is to associate the namespace to a controller. Perhaps what @benlwalker was mentioning in another thread about attach/detach. The difference between the terms attach/detach vs enable/disable is that if the namespace key id is already specified in the controller object than we can just call it |
I think if the goal is the same, we need to pick either attach/detach or enable/disable and move on with single pair |
Unless we plan to support private namespaces (we shouldn't) then the nsids are global to the subsystem and picked when a namespace is attached there. But either way I'd still like to see a use case for this. |
when a namespace is created it is associated with the subsystem/controller, however when a namespace is enabled is when it is exposed to the host. ping @chaitanyahuilgol |
I personally think that when you associate the namespace with the subsystem/controller, it should automatically be exposed to the host. I don't see the need for enable/disable... just remove it when you don't need it and re-add back when you need it again... would love to hear explanation why I'm wrong... |
@glimchb - if you want to pre-provision things and get it all hooked up and make it easy to enable the namespace/volumens enabled on the host, this is very helpful in my experience. |
I still don't understand the use case for this. It's a legitimate thing you can do in the spec, but I don't see what the flow is where you'd need this. It's certainly not in pre-provisioning - you can set everything up before creating the controller to achieve the described effect without using this. |
@jainvipin I saw you suggested adding this...
The text was updated successfully, but these errors were encountered: