Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage: add API for performing the NVMe discovery #161

Open
harshitap26 opened this issue Oct 17, 2022 · 3 comments
Open

Storage: add API for performing the NVMe discovery #161

harshitap26 opened this issue Oct 17, 2022 · 3 comments
Assignees
Labels
Storage APIs or code related to storage area

Comments

@harshitap26
Copy link

No API is available under the Host facing API for performing the NVMe discover command. We need the NVMe discover command to find the target NQN, which is required in the NVMe connect command.

@harshitap26 harshitap26 changed the title Storage: No API available for performing the NVMe disovery Storage: Require API for performing the NVMe disovery Oct 17, 2022
@harshitap26 harshitap26 changed the title Storage: Require API for performing the NVMe disovery Storage: Require API for performing the NVMe discovery Oct 17, 2022
@glimchb glimchb self-assigned this Oct 17, 2022
@glimchb glimchb changed the title Storage: Require API for performing the NVMe discovery Storage: add API for performing the NVMe discovery Oct 17, 2022
@glimchb glimchb added the Storage APIs or code related to storage area label Oct 27, 2022
@benlwalker
Copy link

I believe this is not the correct approach. Instead, when provisioning a back-end volume, specifying a discovery service instead of the real subnqn/ip/port is the right way to handle discovery. In other words, you say "I want to connect to the volume that this discovery service is telling me about" when you create the back end volume.

The reason to do it the way I suggest is because the connection parameters can actually migrate over time, so the xPU needs to remain subscribed to the discovery service indefinitely to track the path changes. You can't just ask the discovery service one time and then use those same parameters forever, in the general case.

Recommend closing this issue and opening one targeted at the nvmf backend to support connect via discovery.

@glimchb
Copy link
Member

glimchb commented Oct 31, 2022

@benlwalker by doing so you assuming xPU vendors implement discovery service that runs all the time and monitors the network... one can use CDC instead of DDC or SPDK start discovery, but this is not all the use cases...
Maybe API for discovery is not instead of discovery but in addition...

@benlwalker
Copy link

I think even in the case that the discovery service isn't continually running and paths never move around, you'd still use the discovery service during the provisioning of the back-end volume rather than having dedicated calls to query it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage APIs or code related to storage area
Projects
None yet
Development

No branches or pull requests

3 participants