Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align username vs dpu_bmc_username everywhere #53

Open
glimchb opened this issue Mar 15, 2024 · 2 comments
Open

Align username vs dpu_bmc_username everywhere #53

glimchb opened this issue Mar 15, 2024 · 2 comments

Comments

@glimchb
Copy link
Member

glimchb commented Mar 15, 2024 •
edited
Loading

also dpu_bmc_password and dpu_bmc_token

example declares username argument
https://github.com/opiproject/ansible-opi-dpu/blob/461d6a8a947a01d17d60168b0f8a7adbf3940229/roles/bmc_reboot/meta/argument_specs.yml
but uses dpu_bmc_username instead
https://github.com/opiproject/ansible-opi-dpu/blob/461d6a8a947a01d17d60168b0f8a7adbf3940229/roles/bmc_reboot/tasks/main.yml
glimchb added a commit to glimchb/ansible-opi-dpu that referenced this issue Mar 26, 2024
@glimchb
fix: update meta args
1abaa67 
Related to opiproject#53

Signed-off-by: Boris Glimcher <[email protected]>
@glimchb glimchb mentioned this issue Mar 26, 2024
Merged
glimchb added a commit to glimchb/ansible-opi-dpu that referenced this issue Mar 26, 2024
@glimchb
fix: update meta args
0780890 
Related to opiproject#53

Signed-off-by: Boris Glimcher <[email protected]>
glimchb added a commit that referenced this issue Mar 26, 2024
@glimchb
fix: update meta args
674a6eb 
Related to #53

Signed-off-by: Boris Glimcher <[email protected]>
@glimchb glimchb changed the title make dpu_bmc_username required variable everywhere Align username vs dpu_bmc_username everywhere Mar 27, 2024
@MAVRICK-1
Copy link

@glimchb can you assign me this issue

@glimchb
Copy link
Member Author

glimchb commented Jul 8, 2024

@MAVRICK-1 let's see firsat how you do on your first PR #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glimchb @MAVRICK-1