Skip to content

Automatically cache resource from UpdateControl patch responses #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csviri opened this issue May 8, 2025 · 1 comment
Closed

Automatically cache resource from UpdateControl patch responses #2786

csviri opened this issue May 8, 2025 · 1 comment
Assignees
Milestone

Comments

@csviri
Copy link
Collaborator

csviri commented May 8, 2025

This can be automatically done safely when parseResourceVersionsForEventFilteringAndCaching is set to true.

If set to false, we should not cache it; this should be expressed clearly in the docs. We should also add a feature flag not to do so.

@csviri csviri added this to the 5.1 milestone May 8, 2025
@csviri csviri self-assigned this May 8, 2025
@csviri csviri linked a pull request May 9, 2025 that will close this issue
@csviri
Copy link
Collaborator Author

csviri commented May 15, 2025

After discussion and thking this though we decided that for now we won't add this functionality to the core to UpdateControl.

In v6 we will probably even go further end remove the current methods: #2797

Since it is quite confusing to have those methods behavior configurable in ConfigurationService.

@csviri csviri closed this as completed May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant