Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSDK v5: Documentation improvements #2624

Closed
ebma16 opened this issue Dec 7, 2024 · 1 comment · Fixed by #2638
Closed

JOSDK v5: Documentation improvements #2624

ebma16 opened this issue Dec 7, 2024 · 1 comment · Fixed by #2638

Comments

@ebma16
Copy link

ebma16 commented Dec 7, 2024

Hey,

I'm currently updating in my project josdk to the 5.0.0-beta1. So I am currently reading through the documentation in order to update the registration of the EventSources in my reconcilers.

I have thought about the following topics/suggestions:

  1. I came across the following examples while updating:

From what I can see, the “InformerConfiguration” class does not provide a “from” method anymore (changed with v5). In the example, this should rather be the class “InformerEventSourceConfiguration”, can that be?

  1. The examples in the documentation (such as the one mentioned above) show a simple configuration of an ES using the “InformerEventSourceConfiguration” class and refer to an example in an integration test. Some configurations are now also carried out via the “InformerConfiguration” class (e.g. setting onUpdateFilter), it would perhaps also be helpful to integrate an example of this into the documentation, or to refer to an integration test that contains such a config, such as this one.

  2. The Migration Guide mentions the prepareEventSources method, but does not describe what needs to be adapted there. Perhaps it would be helpful to refer to the documentation for an example.

  3. This link in the Migration Guide is not accessible and should be adjusted.

  4. This example in the documentation is outdated. It should be updated to context. managedWorkflowAndDependentResourceContext(), right?

What do you think about these topics?

Best regards
Martin

@csviri csviri linked a pull request Dec 16, 2024 that will close this issue
@csviri
Copy link
Collaborator

csviri commented Dec 16, 2024

thank you very much @ebma16 !

I came across the following examples while updating:

I fixed the outdated docs from this section

The Migration Guide mentions the prepareEventSources method, but does not describe what needs to be adapted there. Perhaps it would be helpful to refer to the documentation for an example.

This section was removed, the migration guide simply points to the blog.

This link in the Migration Guide is not accessible and should be adjusted.

fixed it.

This example in the documentation is outdated. It should be updated to context. managedWorkflowAndDependentResourceContext(), right?

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants