Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: good practices validator only warn for empty CRD desc if spec.customresourcedefinitions in csv is not empty #296

Open
HarikrishnanBalagopal opened this issue Sep 15, 2023 · 0 comments

Comments

@HarikrishnanBalagopal
Copy link

if crd.Description == "" {

This warning is always returned, even when you are not using the customresourcedefinitions field. Example:

spec:
  apiservicedefinitions: {}
  customresourcedefinitions: {}

It's even in the docs where the show how to validate the bundle https://sdk.operatorframework.io/docs/advanced-topics/custom-bundle-validation/
image

@HarikrishnanBalagopal HarikrishnanBalagopal changed the title bug: good practices validator always reports CRD description empty even when the definitions field is not being used. bug: good practices validator always reports CRD description empty even when the definitions field is not being used in the CSV. Sep 15, 2023
@grokspawn grokspawn changed the title bug: good practices validator always reports CRD description empty even when the definitions field is not being used in the CSV. RFE: good practices validator only warn for empty CRD desc if spec.customresourcedefinitions in csv is not empty Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant