Recursive DNS implementation #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scareything
approved these changes
Feb 7, 2022
| @@ -31,7 +31,8 @@ typedef int (*dns_fallback_cb)(const char *name, void *ctx, struct in_addr* addr | |||
|
|
|||
| int ziti_dns_setup(tunneler_context tnlr, const char *dns_addr, const char *dns_cidr); | |||
|
|
|||
| void ziti_dns_set_fallback(struct uv_loop_s *l, dns_fallback_cb fb, void *ctx); | |||
| int ziti_dns_set_upstream(uv_loop_t *l, const char *host, uint16_t port); | |||
|
|
|||
| void ziti_dns_set_manager(dns_manager *mgr); | |||
There was a problem hiding this comment.
Can we also remove ziti_dns_set_manager (and the dns_manager types) now?
| @@ -31,7 +31,8 @@ typedef int (*dns_fallback_cb)(const char *name, void *ctx, struct in_addr* addr | |||
|
|
|||
| int ziti_dns_setup(tunneler_context tnlr, const char *dns_addr, const char *dns_cidr); | |||
|
|
|||
| void ziti_dns_set_fallback(struct uv_loop_s *l, dns_fallback_cb fb, void *ctx); | |||
There was a problem hiding this comment.
The dns_fallback_cb typedef (on line 30) is no longer referenced - should it be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.