Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change data source to PyOpenWorm in unit tests #28

Open
travs opened this issue Jun 16, 2015 · 9 comments
Open

Change data source to PyOpenWorm in unit tests #28

travs opened this issue Jun 16, 2015 · 9 comments

Comments

@travs
Copy link

travs commented Jun 16, 2015

These tests should use the NeuroML2 python library to read c302 and compare key features to the contents drawn from PyOpenWorm to be sure they are consistent.

Depends on #27 being completed.

@travs
Copy link
Author

travs commented Jun 16, 2015

@aribrich are you able to make it to the hackathon this Sunday? If so, this would be a good issue to discuss relative to your work on #23.

@aribrich
Copy link
Contributor

@travs I'm planning on going right now. I had submitted a program that would make this comparison, but I'm not sure where we stand on that issue at the moment. Because of that I haven't really done any coding for this in a while. What were you thinking in this regard?

@pgleeson
Copy link
Member

The issue I just created is quite relevant for this issue & the pull request.

@travs
Copy link
Author

travs commented Jun 23, 2015

@aribrich The issue @pgleeson is referring to will be resolved soon, and then we can move forward on getting your code incorporated. Is the program you're speaking of #23 ?

@travs
Copy link
Author

travs commented Jun 30, 2015

@ahrasheed
Your work on #27 is relevant to this as well. Would you be interested in taking this issue on, in tandem with @aribrich ?

@aleph-ra
Copy link
Contributor

@travs Sure. The comparison script by @aribrich raises important questions over the differences between the two spreadsheets.

I think this issue is redundant, considering that right now the difference between connectome in c302 and PyOpenWorm is the same difference that exists between the spreadsheets CElegansNeuronTables.xls and NeuronConnect.xls (source for PyOpenWorm). Once the data is pulled from PyOpenWorm into c302 (by using this script) the tests will essentially be checking if c302 worked correctly to generate correct NeuroML2 files, not making a comparison. And such tests already exist here, except right now they are using CElegansNeuronTables.xls to read the data and not PyOpenWorm. So changing the data source in these tests will make them into the tests required in this issue. Constraints regarding changing the data source just yet are also addressed here.

Would like to know if you guys think otherwise.

@travs
Copy link
Author

travs commented Jul 2, 2015

@ahrasheed That makes sense; perhaps we can rename the issue to reflect what this change would entail (something like "Change data source to PyOpenWorm in unit tests").

Since this is a separate issue form #27, I propose we keep this one open until the requisite changes are made in the unit tests (even if it is only a few lines).

So essentially, this also depends on openworm/owmeta#162 and openworm/owmeta#163, as you say.

Let me know if you think the renaming is correct/sufficient.

@travs travs changed the title Write tests verifying that c302 data matches data from PyOpenWorm Change data source to PyOpenWorm in unit tests Jul 2, 2015
@aleph-ra
Copy link
Contributor

aleph-ra commented Jul 2, 2015

@travs Agree with the name change. Thanks

@pgleeson
Copy link
Member

pgleeson commented Jul 3, 2015

@ahrasheed @travs I agree with that assessment too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants