Skip to content

Version-condition the washr 1.0.1 caveats, retire after two clean releases on washr >= 1.0.2 #41

Description

@larnsce

Successor to #23 (closed: it added the workarounds; this issue retires them). Identified as the top finding of the 2026-07-12 cross-repo coherence review (openwashdata/washr, dev/review-2026-07/cross-repo-coherence.md on branch claude/washr-review-premortem-5idwlc): washr v1.0.2 fixes the root causes of all four caveats (washr #57, #58, #59, #60 plus #63, #64), but nothing open in either repo owned removing the workarounds, which would have silently defeated the patch's purpose.

Do NOT delete the caveats outright (premortem R6 in the washr review: CRAN binary lag, cached libraries, and renv locks mean old washr keeps resolving downstream after the release). Version-condition them instead.

Tasks:

  • skills/create-release/SKILL.md, skills/add-doi/SKILL.md, skills/pkgreview-core/references/standards.md: wrap each washr 1.0.1 caveat in a version condition: run packageVersion("washr") first; apply the caveat steps only when < 1.0.2, skip them when >= 1.0.2 (on a fixed washr the old surgery is harmful: it deletes correct DOI badges and "restores" fields that were never stripped)
  • checklists/metadata.md: same conditioning where caveats appear
  • Bump skills/pkgreview-core/VERSION and record the change in docs/checklist-reconciliation.md (repo rules 1 and 3); if this lands in the same window as the v1.1.0 standard release (Release v1.1.0: gate run, standards update, version bump, tag #32), fold it into that release so standards.md is edited once and the standard bumps once
  • Verify against fixtures/pkgreviewtest with both washr versions if practical, at minimum with the installed one
  • Remove the caveat text entirely only after two consecutive clean downstream releases on washr >= 1.0.2

Timing: blocked on washr v1.0.2 reaching CRAN (openwashdata/washr#66). Implementation of both plans starts September 2026; recommended sequence is the washr release branch first, this issue folded into #32 during the CRAN wait.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions