Skip to content

Data Package Review: Tests & CI/CD #11

Description

@larnsce

Review Checklist

This is step 4 of 4 in the openwashdata package review process.

Review standard version: 1.0.0-dev

Prerequisites

Tasks

  • GitHub Actions workflow for R-CMD-check present (.github/workflows/R-CMD-check.yaml) (now also triggers on dev pushes and PRs)
  • R-CMD-check badge added to README.Rmd
  • Package passes devtools::check() with no errors or warnings; any notes are explained in the PR (0 errors, 0 warnings, 0 notes)
  • Examples run successfully
  • Data loads correctly (guarded by a new testthat suite with 24 assertions)

Badge markdown (replace PACKAGENAME):

[![R-CMD-check](https://github.com/openwashdata/PACKAGENAME/workflows/R-CMD-check/badge.svg)](https://github.com/openwashdata/PACKAGENAME/actions)

Files to review or create

  • .github/workflows/R-CMD-check.yaml (create if missing)
  • README.Rmd (add badge)
  • tests/testthat/ (if it exists)

Next Steps

  1. Run /review-issue [this issue's number] to work on this issue
  2. Create a PR to the dev branch
  3. After merging, run /review-complete to create the final PR from dev to main

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    pkgreviewopenwashdata package reviewpkgreview-testsReview area 4: tests and CI/CD

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions