Skip to content

Add coverage for objective_integrity kind_recall non-dict and out-of-range guards #2335

Description

@galuis116

benchmark/objective_integrity._kind_recall_problems has two guard branches that are never exercised by the test suite:

  • line 188if not isinstance(objective, dict): return ["objective is not a dict"]
  • line 195if not _is_ratio(value): return [f"kind_recall={value!r} is not a ratio in [0, 1]"]

test_kind_recall_problems_helper covers the empty and bool-kind_recall cases, but not these two — even though the sibling helper's test, test_recall_field_problems_helper, already covers the same non-dict and out-of-range branches for _recall_field_problems.

Ask

Add the two missing assertions to test_kind_recall_problems_helper (a non-dict objective and an out-of-range kind_recall), mirroring the sibling helper's coverage. Tests only.

Metadata

Metadata

Assignees

No one assigned

    Labels

    benchmarkEvaluation harnesstestsTest suite

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions