Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download file name has extra path parts prepended #14

Open
macumber opened this issue Sep 5, 2024 · 2 comments
Open

Download file name has extra path parts prepended #14

macumber opened this issue Sep 5, 2024 · 2 comments
Labels
downloads Related to the downloads feature

Comments

@macumber
Copy link
Collaborator

macumber commented Sep 5, 2024

openstudioreleases\src\releases\ReleaseInfo.tsx is setting the download attribute of the download link to asset.name (e.g. OpenStudioApplication-1.8.0-rc2+cd925a1005-macOS11-x86_64.dmg) but the downloaded file is assets_v1.8.0-rc2_OpenStudioApplication-1.8.0-rc2+cd925a1005-macOS11-x86_64.dmg
@macumber macumber added the downloads Related to the downloads feature label Sep 5, 2024
@jmarrec
Copy link
Contributor

jmarrec commented Sep 23, 2024

I noticed that too!

@jmarrec
Copy link
Contributor

jmarrec commented Sep 23, 2024

"download" attribute is only honored for links to resources with the same-origin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
downloads Related to the downloads feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@macumber @jmarrec