-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement backup & reboot functionality #2
Comments
Reboot is a bit difficult as I'm not sure what to do about losing the connection to the device when the device reboots. Should the callback return when ADB reports success for the reboot command, or when the device becomes accessible again? Is ADB even available in recovery/bootloader mode? Backup should also be doable, but it might take a while to implement it as we don't need it here at work right now... Our code is CoffeeScript mainly because it makes writing callback-heavy code more enjoyable. But you're right, it takes a while to get used to it. If it helps, try running Personally I find that the biggest differences are that curly braces are always left out, parentheses can be omitted (e.g. Alternatively you could just write your additions in JavaScript, as .js files can be As for implementing a new API method, aside from the complexities introduced by rebooting, the basic idea is that you create Anyway we'd really appreciate contributors so I hope you can look beyond the language! |
these features would be nice. A possible API:
Backup
client.backup(serial, options, callback)
where the options could look like this:
Reboot
client.rebootRecovery(serial, callback)
client.rebootBootloader(serial, callback)
adb reboot [bootloader|recovery]
I would like to contribute, but I can't get my head around coffescript.
The text was updated successfully, but these errors were encountered: