Skip to content

Commit 8db03cc

Browse files
refactor: format cobj/ and update .gitignore (#205)
1 parent 7d8dfcf commit 8db03cc

File tree

8 files changed

+344
-313
lines changed

8 files changed

+344
-313
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ cobj/Makefile
88
cobj/cobj
99
cobj/*.o
1010
config.h
11+
config.h.in~
1112
config.log
1213
config.status
1314
config/Makefile

check-format

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
#!/bin/bash
22
cd libcobj && ./check-format
3+
cd ../cobj && ./check-format

cobj/cobj.c

Lines changed: 74 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@
2222
#include "config.h"
2323
#include "defaults.h"
2424

25+
#include <errno.h>
2526
#include <setjmp.h>
2627
#include <stdarg.h>
2728
#include <stdio.h>
2829
#include <stdlib.h>
2930
#include <string.h>
30-
#include <errno.h>
3131
#ifdef HAVE_SYS_TYPES_H
3232
#include <sys/types.h>
3333
#endif
@@ -778,7 +778,8 @@ static void cobc_print_usage(void) {
778778
puts(_(" -free_1col_aster Use free(1col_aster) source "
779779
"format"));
780780
puts(_(" -g Enable Java compiler debug"));
781-
puts(_(" -debug Enable all run-time error checking"));
781+
puts(_(" -debug Enable all run-time error "
782+
"checking"));
782783
puts(_(" -o <dir>, -class-file-dir=<dir> Place class files into <dir>"));
783784
puts(_(" -j <dir>, -java-source-dir=<dir> Place Java files into <dir>"));
784785
puts(_(" -E Preprocess only; do not compile "
@@ -796,15 +797,22 @@ static void cobc_print_usage(void) {
796797
_(" -assign_external Set the file assign to external"));
797798
puts(_(" -constant Define <name> to <value> for $IF "
798799
"statement"));
799-
puts(_(" -fdefaultbyte=<value> default initialization for fields without VALUE, may be one of"));
800-
puts(_(" * decimal 0..255 representing a character"));
801-
puts(_(" * hexdecimal 0x00..0xFF representing a character"));
802-
puts(_(" * octodecimal 00..0377 representing a character"));
800+
puts(_(" -fdefaultbyte=<value> default initialization for "
801+
"fields without VALUE, may be one of"));
802+
puts(_(" * decimal 0..255 representing a "
803+
"character"));
804+
puts(_(" * hexdecimal 0x00..0xFF "
805+
"representing a character"));
806+
puts(_(" * octodecimal 00..0377 "
807+
"representing a character"));
803808
puts(_(" -java-package(=<package name>) Specify the package name of the "
804809
"generated source code"));
805-
puts(_(" -jar Create <PROGRAM-ID>.jar and remove class files"));
806-
puts(_(" -single-jar=<JAR file name> Create <JAR file name>.jar and remove class files"));
807-
puts(_(" The JAR file contains all class files of all specified COBOL programs"));
810+
puts(_(" -jar Create <PROGRAM-ID>.jar and "
811+
"remove class files"));
812+
puts(_(" -single-jar=<JAR file name> Create <JAR file name>.jar and "
813+
"remove class files"));
814+
puts(_(" The JAR file contains all class "
815+
"files of all specified COBOL programs"));
808816
// puts(_(" -edit-code-command(=<command>) Specify the command to edit
809817
// java " "source code. See script/spring_batch_tasklet.sh in opensource COBOL
810818
//" "4J for details."));
@@ -1009,39 +1017,40 @@ static int process_command_line(const int argc, char *argv[]) {
10091017
if (optarg) {
10101018
cb_java_package_name = optarg;
10111019
}
1012-
break;
1020+
break;
10131021

1014-
case OPTION_ID_JAR:
1015-
cb_flag_jar = 1;
1016-
break;
1022+
case OPTION_ID_JAR:
1023+
cb_flag_jar = 1;
1024+
break;
10171025

1018-
case OPTION_ID_SINGLE_JAR:
1019-
cb_flag_jar = 1;
1020-
if(optarg) {
1021-
int len = strlen(optarg);
1022-
if(len != 0) {
1026+
case OPTION_ID_SINGLE_JAR:
1027+
cb_flag_jar = 1;
1028+
if (optarg) {
1029+
int len = strlen(optarg);
1030+
if (len != 0) {
10231031
cb_single_jar_name = malloc(len + 1);
10241032
strcpy(cb_single_jar_name, optarg);
10251033
break;
1034+
}
1035+
}
1036+
fprintf(stderr, "Warning - An invalid name for a jar file\n");
1037+
fflush(stderr);
1038+
break;
1039+
1040+
case OPTION_ID_DEFAULT_BYTE:
1041+
if (optarg) {
1042+
char *e;
1043+
unsigned long byte = strtoul(optarg, &e, 0);
1044+
if (*e == '\0' && errno != EINVAL && errno != ERANGE && 0 <= byte &&
1045+
byte <= 0xFF) {
1046+
cb_default_byte = byte;
1047+
cb_default_byte_specified = 1;
1048+
break;
1049+
}
10261050
}
1027-
}
1028-
fprintf(stderr, "Warning - An invalid name for a jar file\n");
1029-
fflush(stderr);
1030-
break;
1031-
1032-
case OPTION_ID_DEFAULT_BYTE:
1033-
if(optarg) {
1034-
char* e;
1035-
unsigned long byte = strtoul(optarg, &e, 0);
1036-
if(*e == '\0' && errno != EINVAL && errno != ERANGE && 0 <= byte && byte <= 0xFF) {
1037-
cb_default_byte = byte;
1038-
cb_default_byte_specified = 1;
1039-
break;
1040-
}
1041-
}
1042-
fprintf(stderr, "Warning - '%s' is an invalid 1-byte value\n", optarg);
1043-
fflush(stderr);
1044-
break;
1051+
fprintf(stderr, "Warning - '%s' is an invalid 1-byte value\n", optarg);
1052+
fflush(stderr);
1053+
break;
10451054

10461055
case '3': /* --constant */
10471056
if (optarg) {
@@ -1665,7 +1674,7 @@ static int process_translate(struct filename *fn) {
16651674
return 0;
16661675
}
16671676

1668-
static void create_module_info_java(char* source_dir, char* package_name) {
1677+
static void create_module_info_java(char *source_dir, char *package_name) {
16691678
char path[COB_MEDIUM_BUFF];
16701679
sprintf(path, "%s/module-info.java", source_dir);
16711680
FILE *f = fopen(path, "w");
@@ -1676,11 +1685,11 @@ static void create_module_info_java(char* source_dir, char* package_name) {
16761685
fclose(f);
16771686
}
16781687

1679-
static package_name_to_path(char* buff, char* package_name) {
1680-
char* b_p = buff;
1681-
char* p_p = package_name;
1682-
for(; *p_p; ++p_p, ++b_p) {
1683-
if(*p_p == '.') {
1688+
static package_name_to_path(char *buff, char *package_name) {
1689+
char *b_p = buff;
1690+
char *p_p = package_name;
1691+
for (; *p_p; ++p_p, ++b_p) {
1692+
if (*p_p == '.') {
16841693
*b_p = '/';
16851694
} else {
16861695
*b_p = *p_p;
@@ -1703,36 +1712,39 @@ static int process_compile(struct filename *fn) {
17031712
char *output_name_a = output_name == NULL ? "./" : output_name;
17041713
char *java_source_dir_a = java_source_dir == NULL ? "./" : java_source_dir;
17051714

1706-
if(!cb_single_jar_name) {
1715+
if (!cb_single_jar_name) {
17071716
char **program_id;
17081717
for (program_id = program_id_list; *program_id; ++program_id) {
1709-
sprintf(buff, "javac %s -encoding SJIS -d %s %s/%s.java",
1710-
cob_java_flags, output_name_a, java_source_dir_a, *program_id);
1718+
sprintf(buff, "javac %s -encoding SJIS -d %s %s/%s.java", cob_java_flags,
1719+
output_name_a, java_source_dir_a, *program_id);
17111720
ret = process(buff);
17121721

1713-
if(ret) {
1722+
if (ret) {
17141723
return ret;
17151724
}
1716-
if(cb_flag_jar) {
1725+
if (cb_flag_jar) {
17171726
char *package_dir;
1718-
if(cb_java_package_name) {
1727+
if (cb_java_package_name) {
17191728
package_name_to_path(buff2, cb_java_package_name);
17201729
package_dir = buff2;
17211730
} else {
17221731
package_dir = ".";
17231732
}
1724-
sprintf(buff, "cd %s && jar --create --main-class=%s --file=%s.jar %s/*.class",
1725-
output_name_a, *program_id, *program_id, package_dir);
1733+
sprintf(
1734+
buff,
1735+
"cd %s && jar --create --main-class=%s --file=%s.jar %s/*.class",
1736+
output_name_a, *program_id, *program_id, package_dir);
17261737
ret = process(buff);
1727-
if(ret) {
1738+
if (ret) {
17281739
return ret;
17291740
}
1730-
sprintf(buff, "rm -rf %s/%s.class %s/%s$*.class", output_name_a, *program_id, output_name_a, *program_id);
1741+
sprintf(buff, "rm -rf %s/%s.class %s/%s$*.class", output_name_a,
1742+
*program_id, output_name_a, *program_id);
17311743
process(buff);
17321744
}
17331745
}
17341746
return ret;
1735-
}
1747+
}
17361748
}
17371749

17381750
static int process_build_module(struct filename *fn) {
@@ -1964,24 +1976,24 @@ int process_build_single_jar() {
19641976
char *output_name_a = output_name == NULL ? "./" : output_name;
19651977
char *java_source_dir_a = java_source_dir == NULL ? "./" : java_source_dir;
19661978

1967-
sprintf(buff, "javac %s -encoding SJIS -d %s %s/*.java",
1968-
cob_java_flags, output_name_a, java_source_dir_a);
1979+
sprintf(buff, "javac %s -encoding SJIS -d %s %s/*.java", cob_java_flags,
1980+
output_name_a, java_source_dir_a);
19691981

19701982
ret = process(buff);
1971-
if(ret) {
1983+
if (ret) {
19721984
return ret;
19731985
}
19741986

19751987
char *package_dir;
1976-
if(cb_java_package_name) {
1988+
if (cb_java_package_name) {
19771989
package_name_to_path(buff2, cb_java_package_name);
19781990
package_dir = buff2;
19791991
} else {
19801992
package_dir = ".";
19811993
}
19821994

1983-
sprintf(buff, "cd %s && jar --create --file=%s %s/*.class",
1984-
output_name_a, cb_single_jar_name, package_dir);
1995+
sprintf(buff, "cd %s && jar --create --file=%s %s/*.class", output_name_a,
1996+
cb_single_jar_name, package_dir);
19851997
ret = process(buff);
19861998
sprintf(buff, "rm -f %s/%s/*.class #aaa", output_name_a, package_dir);
19871999
process(buff);
@@ -2237,7 +2249,8 @@ int main(int argc, char *argv[]) {
22372249
}
22382250

22392251
/* Compile */
2240-
if (!cb_single_jar_name && (cb_compile_level == CB_LEVEL_COMPILE || cb_compile_level == CB_LEVEL_MODULE)) {
2252+
if (!cb_single_jar_name && (cb_compile_level == CB_LEVEL_COMPILE ||
2253+
cb_compile_level == CB_LEVEL_MODULE)) {
22412254
if (process_compile(fn) != 0) {
22422255
cobc_clean_up(status);
22432256
return status;
@@ -2256,7 +2269,7 @@ int main(int argc, char *argv[]) {
22562269
}
22572270
}
22582271

2259-
if(cb_single_jar_name) {
2272+
if (cb_single_jar_name) {
22602273
process_build_single_jar();
22612274
}
22622275

0 commit comments

Comments
 (0)