From a8a82237794610190fdd48b2f4f10893104075b4 Mon Sep 17 00:00:00 2001 From: Nick Bianco Date: Thu, 30 Jan 2025 12:12:32 -0800 Subject: [PATCH 1/2] Remove restriction in PolynomialPathFitter that paths must depend on 6 or less coordinates --- OpenSim/Actuators/PolynomialPathFitter.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/OpenSim/Actuators/PolynomialPathFitter.cpp b/OpenSim/Actuators/PolynomialPathFitter.cpp index df5d857f19..2bdc985a07 100644 --- a/OpenSim/Actuators/PolynomialPathFitter.cpp +++ b/OpenSim/Actuators/PolynomialPathFitter.cpp @@ -842,10 +842,6 @@ void PolynomialPathFitter::filterSampledData(const Model& model, momentArms.removeColumn(label); } else { momentArmMap[path].push_back(coordinate); - OPENSIM_THROW_IF_FRMOBJ(momentArmMap[path].size() > 6, - Exception, - "The path '{}' depends on more than 6 coordinates. " - "This is not supported.", path) } } } From 3c00c00a2ee428a2782214bfb8aed5fca8cfa785 Mon Sep 17 00:00:00 2001 From: Nick Bianco Date: Thu, 30 Jan 2025 12:22:23 -0800 Subject: [PATCH 2/2] Update CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index cd381e929a..1eb3757c96 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -65,6 +65,7 @@ v4.6 decorations were emitted for both `true` and `false`, resulting in double-emission). - It will now check for NaNed vectors coming from the underlying expression, skipping emission if one is detected (previously: it would emit decorations with `NaN`ed transforms). +- `PolynomialPathFitter` now allows fitting paths that depend on more than 6 coordinates, matching recent changes to `MultivariatePolynomialFunction` (#4001). v4.5.1 ======