Skip to content

Commit c42ba29

Browse files
Merge pull request #2331 from smg247/ann-removal-fix-micro
TRT-2068: Reintroduce non-suite annotation removal
2 parents b94367c + 9699009 commit c42ba29

File tree

4 files changed

+1495
-1854
lines changed

4 files changed

+1495
-1854
lines changed

openshift-hack/cmd/k8s-tests-ext/environment_selectors.go

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,23 @@ func filterByExternalConnectivity(specs et.ExtensionTestSpecs) {
145145
// because of pullthrough not supporting ICSP (https://bugzilla.redhat.com/show_bug.cgi?id=1918376)
146146
"Disconnected": {
147147
"[sig-network] Networking should provide Internet connection for containers",
148+
// The following tests are all duplicated from the Proxied list as the concepts of Disconnected and Proxied
149+
// have gotten muddied. The following tests should all be skipped when accessing the cluster via a proxy,
150+
// this is a separate concept from external connectivity that will later be formalized with a new environment
151+
// flag in https://issues.redhat.com/browse/TRT-1854.
152+
// TODO(sgoeddel): remove the following, duplicated, tests once this is complete
153+
"[sig-cli] Kubectl client Simple pod should support exec through an HTTP proxy",
154+
"[sig-cli] Kubectl client Simple pod should support exec through kubectl proxy",
155+
"[sig-node] Pods should support retrieving logs from the container over websockets",
156+
"[sig-node] Pods should support retrieving logs from the container over websockets",
157+
"[sig-cli] Kubectl Port forwarding With a server listening on localhost should support forwarding over websockets",
158+
"[sig-cli] Kubectl Port forwarding With a server listening on 0.0.0.0 should support forwarding over websockets",
159+
"[sig-node] Pods should support remote command execution over websockets",
148160
},
149161
// These tests are skipped when openshift-tests needs to use a proxy to reach the
150162
// cluster -- either because the test won't work while proxied, or because the test
151163
// itself is testing a functionality using it's own proxy.
152-
"Proxy": {
164+
"Proxied": {
153165
// These tests setup their own proxy, which won't work when we need to access the
154166
// cluster through a proxy.
155167
"[sig-cli] Kubectl client Simple pod should support exec through an HTTP proxy",
@@ -160,7 +172,7 @@ func filterByExternalConnectivity(specs et.ExtensionTestSpecs) {
160172
"[sig-cli] Kubectl Port forwarding With a server listening on localhost should support forwarding over websockets",
161173
"[sig-cli] Kubectl Port forwarding With a server listening on 0.0.0.0 should support forwarding over websockets",
162174
"[sig-node] Pods should support remote command execution over websockets",
163-
// These tests are flacky and require internet access
175+
// These tests are flaky and require internet access
164176
// See https://bugzilla.redhat.com/show_bug.cgi?id=2019375
165177
"[sig-network] DNS should resolve DNS of partial qualified names for services",
166178
"[sig-network] DNS should provide DNS for the cluster",
@@ -184,7 +196,7 @@ func filterByExternalConnectivity(specs et.ExtensionTestSpecs) {
184196
// filterByTopology is a helper function to do, simple, "NameContains" filtering on tests by topology
185197
func filterByTopology(specs et.ExtensionTestSpecs) {
186198
var topologyExclusions = map[string][]string{
187-
"SingleReplicaTopology": {
199+
"SingleReplica": {
188200
"[sig-apps] Daemon set [Serial] should rollback without unnecessary restarts [Conformance]",
189201
"[sig-node] NoExecuteTaintManager Single Pod [Serial] doesn't evict pod with tolerations from tainted nodes",
190202
"[sig-node] NoExecuteTaintManager Single Pod [Serial] eventually evict pod with finite tolerations from tainted nodes",

openshift-hack/cmd/k8s-tests-ext/labels.go

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,29 @@ func addLabelsToSpecs(specs et.ExtensionTestSpecs) {
3838

3939
"[sig-network] IngressClass [Feature:Ingress] should set default value on new IngressClass", //https://bugzilla.redhat.com/show_bug.cgi?id=1833583
4040
},
41+
"[sig-node]": {
42+
"[NodeConformance]",
43+
"NodeLease",
44+
"lease API",
45+
"[NodeFeature",
46+
"[NodeAlphaFeature",
47+
"Probing container",
48+
"Security Context When creating a",
49+
"Downward API should create a pod that prints his name and namespace",
50+
"Liveness liveness pods should be automatically restarted",
51+
"Secret should create a pod that reads a secret",
52+
"Pods should delete a collection of pods",
53+
"Pods should run through the lifecycle of Pods and PodStatus",
54+
},
55+
"[sig-cluster-lifecycle]": {
56+
"Feature:ClusterAutoscalerScalability",
57+
"recreate nodes and ensure they function",
58+
},
59+
"[sig-arch]": {
60+
// not run, assigned to arch as catch-all
61+
"[Feature:GKELocalSSD]",
62+
"[Feature:GKENodePool]",
63+
},
4164
}
4265

4366
for label, names := range namesByLabel {

0 commit comments

Comments
 (0)