|
1 | 1 | --- |
2 | 2 | title: metrics-collection-profiles |
3 | 3 | authors: |
4 | | - - @JoaoBraveCoding |
| 4 | + - JoaoBraveCoding |
5 | 5 | reviewers: |
6 | | - - @openshift/openshift-team-monitoring |
| 6 | + - openshift/openshift-team-monitoring |
7 | 7 | approvers: |
8 | 8 | - TBD |
9 | 9 | api-approvers: "None" |
@@ -417,8 +417,11 @@ Initial proofs-of-concept: |
417 | 417 |
|
418 | 418 | - Make CMO injecting metric relabelling for all service monitors based on the |
419 | 419 | rules being deployed, but this is not a good idea because: |
420 | | - - CMO acting behind the back of other operators isn't probably a very good |
421 | | - idea (less explicit, more brittle); |
| 420 | + - CMO acting behind the back of other operators isn't a good principle (less |
| 421 | + explicit, more brittle), it would require CMO to watch the components |
| 422 | + monitors and generates new resources that would be reconciled by |
| 423 | + prometheus-operator instead of the original ones, this would also translate |
| 424 | + into a nightmare from a maintainability point of view; |
422 | 425 | - it's likely to be less efficient because the relabeling configs would be |
423 | 426 | very complex and expensive in terms of processing. |
424 | 427 | - Hypershift implements a [similar |
@@ -451,6 +454,10 @@ Initial proofs-of-concept: |
451 | 454 | set of metrics that are only consumed when the minimal profile is enabled. |
452 | 455 | However, customers are also able to extend this minimal profile with regexes to |
453 | 456 | include metrics which might be interesting to them. |
| 457 | +- Leverage [installer capabilities](https://docs.google.com/document/d/1I-YT7LKKDHSBLB6Hmg0tZ54DWjrAxlVdXxlViShMu-0/edit#heading=h.848jsje80fru) |
| 458 | + - After some consideration we decided to abandon this idea since it would only |
| 459 | + work for resources controlled by CVO which is not the case for the majority |
| 460 | + of ServiceMonitors. |
454 | 461 |
|
455 | 462 | ## Infrastructure Needed [optional] |
456 | 463 |
|
|
0 commit comments