Skip to content

Commit 5b8069c

Browse files
JoaoBraveCodingrexagod
authored andcommitted
Address some other review comments
1 parent badf0bf commit 5b8069c

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

enhancements/monitoring/metrics-collection-profiles.md

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
---
22
title: metrics-collection-profiles
33
authors:
4-
- @JoaoBraveCoding
4+
- JoaoBraveCoding
55
reviewers:
6-
- @openshift/openshift-team-monitoring
6+
- openshift/openshift-team-monitoring
77
approvers:
88
- TBD
99
api-approvers: "None"
@@ -417,8 +417,11 @@ Initial proofs-of-concept:
417417

418418
- Make CMO injecting metric relabelling for all service monitors based on the
419419
rules being deployed, but this is not a good idea because:
420-
- CMO acting behind the back of other operators isn't probably a very good
421-
idea (less explicit, more brittle);
420+
- CMO acting behind the back of other operators isn't a good principle (less
421+
explicit, more brittle), it would require CMO to watch the components
422+
monitors and generates new resources that would be reconciled by
423+
prometheus-operator instead of the original ones, this would also translate
424+
into a nightmare from a maintainability point of view;
422425
- it's likely to be less efficient because the relabeling configs would be
423426
very complex and expensive in terms of processing.
424427
- Hypershift implements a [similar
@@ -451,6 +454,10 @@ Initial proofs-of-concept:
451454
set of metrics that are only consumed when the minimal profile is enabled.
452455
However, customers are also able to extend this minimal profile with regexes to
453456
include metrics which might be interesting to them.
457+
- Leverage [installer capabilities](https://docs.google.com/document/d/1I-YT7LKKDHSBLB6Hmg0tZ54DWjrAxlVdXxlViShMu-0/edit#heading=h.848jsje80fru)
458+
- After some consideration we decided to abandon this idea since it would only
459+
work for resources controlled by CVO which is not the case for the majority
460+
of ServiceMonitors.
454461

455462
## Infrastructure Needed [optional]
456463

0 commit comments

Comments
 (0)