Skip to content

Commit 4dfa34f

Browse files
fix: data source picker is remounted multiple times (#1131) (#1137)
(cherry picked from commit 7deec89) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 parent a239f6f commit 4dfa34f

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

public/components/DataSourceAlertsCard/DataSourceAlertsCard.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
import React, { useCallback, useEffect, useState } from "react";
6+
import React, { useCallback, useEffect, useMemo, useState } from "react";
77
import { EuiBadge, EuiDescriptionList, EuiEmptyPrompt, EuiFlexGroup, EuiFlexItem, EuiHorizontalRule, EuiLink, EuiLoadingContent, EuiPanel, EuiText, EuiTitle } from "@elastic/eui";
88
import { DataSourceManagementPluginSetup, DataSourceOption } from "../../../../../src/plugins/data_source_management/public";
99
import { getApplication, getClient, getNotifications, getSavedObjectsClient } from "../../services";
@@ -18,7 +18,13 @@ export interface DataSourceAlertsCardProps {
1818
}
1919

2020
export const DataSourceAlertsCard: React.FC<DataSourceAlertsCardProps> = ({ getDataSourceMenu }) => {
21-
const DataSourceSelector = getDataSourceMenu?.();
21+
const DataSourceSelector = useMemo(() => {
22+
if (getDataSourceMenu) {
23+
return getDataSourceMenu();
24+
}
25+
26+
return null;
27+
}, [getDataSourceMenu]);
2228
const [loading, setLoading] = useState(false);
2329
const [dataSource, setDataSource] = useState<DataSourceOption>({
2430
label: 'Local cluster',

0 commit comments

Comments
 (0)