Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
augment_profile
inskin.scad
inserts new vertices in a profile so that the result has a given number of vertices. Currently, the order of insertions is not specified, and in some cases the new vertices cause distortion.This profile (in context of
extrusion.scad
) demonstrates the issue: the cylinder is visibly distorted:This image shows the distortion.
The example above is artificial, but the issue comes up when combining profiles that you naturally produce with different vertex counts.
This pull requests introduces
insert_extra_vertices_1
which distributes new vertices uniformly around the length of the profile, resulting in much smaller distortions.I'll be happy to polish the code if need be.